Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2682683002: [ReadingList] Unittests on ReadingListCollectionViewItem presented data. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ReadingList] Unittests on ReadingListCollectionViewItem presented data. Add unittests to check that data presented in the ReadingListViewController is the correct one. - The title as text - The formatted URL as detail text - The distilled URL as source for the favicon - The distillation status for the badge. If the entry is not processed, use the URL for the favicon. BUG=689505 Review-Url: https://codereview.chromium.org/2682683002 Cr-Commit-Position: refs/heads/master@{#448942} Committed: https://chromium.googlesource.com/chromium/src/+/22a5bf0558cc1d567ee88a145e9095dcb22adfcb

Patch Set 1 #

Patch Set 2 : fix deps #

Total comments: 2

Patch Set 3 : fix deps again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm View 3 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Olivier
3 years, 10 months ago (2017-02-07 13:51:29 UTC) #2
gambard
lgtm https://codereview.chromium.org/2682683002/diff/20001/ios/chrome/browser/ui/reading_list/BUILD.gn File ios/chrome/browser/ui/reading_list/BUILD.gn (right): https://codereview.chromium.org/2682683002/diff/20001/ios/chrome/browser/ui/reading_list/BUILD.gn#newcode100 ios/chrome/browser/ui/reading_list/BUILD.gn:100: "//components/url_formatter:url_formatter", Do you need the :url_formatter?
3 years, 10 months ago (2017-02-07 17:20:49 UTC) #3
Olivier
https://codereview.chromium.org/2682683002/diff/20001/ios/chrome/browser/ui/reading_list/BUILD.gn File ios/chrome/browser/ui/reading_list/BUILD.gn (right): https://codereview.chromium.org/2682683002/diff/20001/ios/chrome/browser/ui/reading_list/BUILD.gn#newcode100 ios/chrome/browser/ui/reading_list/BUILD.gn:100: "//components/url_formatter:url_formatter", On 2017/02/07 17:20:48, gambard wrote: > Do you ...
3 years, 10 months ago (2017-02-07 17:31:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682683002/40001
3 years, 10 months ago (2017-02-08 09:11:11 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 10:13:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/22a5bf0558cc1d567ee88a145e90...

Powered by Google App Engine
This is Rietveld 408576698