Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

Issue 2682683002: [ReadingList] Unittests on ReadingListCollectionViewItem presented data. (Closed)
Patch Set: fix deps again Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
index 3b3bc2377544330407d23c3333f80b672205607f..de8244f3b7ab6ab07a90e6a0f99c927ad0f290be 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
@@ -10,6 +10,7 @@
#include "base/mac/scoped_nsobject.h"
#include "base/memory/ptr_util.h"
#include "base/single_thread_task_runner.h"
+#include "base/strings/sys_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/favicon/core/favicon_client.h"
#include "components/favicon/core/favicon_service.h"
@@ -17,6 +18,7 @@
#include "components/reading_list/ios/reading_list_model.h"
#include "components/reading_list/ios/reading_list_model_impl.h"
#include "components/reading_list/ios/reading_list_model_storage.h"
+#include "components/url_formatter/url_formatter.h"
#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
#include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
@@ -169,3 +171,60 @@ TEST_F(ReadingListCollectionViewControllerTest, OpensItems) {
EXPECT_OCMOCK_VERIFY(mock_delegate_);
}
+
+// Tests that the ReadingListCollectionView is creating
+// ReadingListCollectionViewItem with the correct informations.
+TEST_F(ReadingListCollectionViewControllerTest,
+ TestItemInitializationUndistilled) {
+ // Setup.
+ GURL url("https://chromium.org");
+ std::string title("Chromium");
+ reading_list_model_->AddEntry(url, title,
+ reading_list::ADDED_VIA_CURRENT_APP);
+ // Load view.
+ [reading_list_view_controller_ view];
+ DCHECK([reading_list_view_controller_.get().collectionView
+ numberOfItemsInSection:0] == 1);
+ NSIndexPath* indexPath = [NSIndexPath indexPathForItem:0 inSection:0];
+ ReadingListCollectionViewItem* readingListItem =
+ base::mac::ObjCCastStrict<ReadingListCollectionViewItem>(
+ [[reading_list_view_controller_ collectionViewModel]
+ itemAtIndexPath:indexPath]);
+ EXPECT_EQ(base::SysNSStringToUTF8([readingListItem text]), title);
+ EXPECT_EQ([readingListItem url], url);
+ EXPECT_EQ(base::SysNSStringToUTF16([readingListItem detailText]),
+ url_formatter::FormatUrl(url));
+ EXPECT_EQ([readingListItem faviconPageURL], url);
+ EXPECT_EQ([readingListItem distillationState], ReadingListEntry::WAITING);
+}
+
+// Tests that the ReadingListCollectionView is creating
+// ReadingListCollectionViewItem with the correct informations for distilled
+// items.
+TEST_F(ReadingListCollectionViewControllerTest,
+ TestItemInitializationDistilled) {
+ // Setup.
+ GURL url("https://chromium.org");
+ std::string title("Chromium");
+ GURL distilled_url("https://chromium.org/distilled");
+ base::FilePath distilled_path("/distilled/path");
+ reading_list_model_->AddEntry(url, title,
+ reading_list::ADDED_VIA_CURRENT_APP);
+ reading_list_model_->SetEntryDistilledInfo(url, distilled_path,
+ distilled_url);
+ // Load view.
+ [reading_list_view_controller_ view];
+ DCHECK([reading_list_view_controller_.get().collectionView
+ numberOfItemsInSection:0] == 1);
+ NSIndexPath* indexPath = [NSIndexPath indexPathForItem:0 inSection:0];
+ ReadingListCollectionViewItem* readingListItem =
+ base::mac::ObjCCastStrict<ReadingListCollectionViewItem>(
+ [[reading_list_view_controller_ collectionViewModel]
+ itemAtIndexPath:indexPath]);
+ EXPECT_EQ(base::SysNSStringToUTF8([readingListItem text]), title);
+ EXPECT_EQ([readingListItem url], url);
+ EXPECT_EQ(base::SysNSStringToUTF16([readingListItem detailText]),
+ url_formatter::FormatUrl(url));
+ EXPECT_EQ([readingListItem faviconPageURL], distilled_url);
+ EXPECT_EQ([readingListItem distillationState], ReadingListEntry::PROCESSED);
+}
« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698