Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2682533002: Fix PingLoaderTest crashing the next test (Closed)

Created:
3 years, 10 months ago by Nate Chapin
Modified:
3 years, 10 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PingLoaderTest crashing the next test Pings can't be cancelled or otherwise accessed once started, so ensure the mocked network request is served before the test completes and the mocked load is unregistered. BUG=682567 Review-Url: https://codereview.chromium.org/2682533002 Cr-Commit-Position: refs/heads/master@{#448693} Committed: https://chromium.googlesource.com/chromium/src/+/2d15a4c1a0667a7e9f6d46946a39ba4a79be518f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nate Chapin
toyoshim@: Would you like to review, since you filed the bug? :)
3 years, 10 months ago (2017-02-06 23:54:38 UTC) #4
Takashi Toyoshima
thanks. lgtm.
3 years, 10 months ago (2017-02-07 07:18:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682533002/1
3 years, 10 months ago (2017-02-07 19:19:13 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:29:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d15a4c1a0667a7e9f6d46946a39...

Powered by Google App Engine
This is Rietveld 408576698