Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/core/loader/PingLoaderTest.cpp

Issue 2682533002: Fix PingLoaderTest crashing the next test (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp b/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
index f96f9b70dd62509c1f93bc7ae02c792d5d687fb7..41ffc4579815822b1d5b012c4f912c4f7e0984d7 100644
--- a/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
@@ -64,6 +64,9 @@ class PingLoaderTest : public ::testing::Test {
EXPECT_EQ(destinationURL.getString(),
pingRequest.httpHeaderField("Ping-To"));
}
+ // Serve the ping request, since it will otherwise bleed in to the next
+ // test, and once begun there is no way to cancel it directly.
+ Platform::current()->getURLLoaderMockFactory()->serveAsynchronousRequests();
return pingRequest;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698