Use TaskScheduler in directory_lister.cc.

Use TaskScheduler in directory_lister.cc.

Instead of taking an external TaskRunner, post directly to
TaskScheduler. This changes removes a call to the deprecated
WorkerPool::GetTaskRunner method.

The following traits are used to post to TaskScheduler:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
Review-Url: https://codereview.chromium.org/2682523002
Cr-Commit-Position: refs/heads/master@{#449599}
Committed: https://chromium.googlesource.com/chromium/src/+/9f0b47853110ba3becfea5ca2e447588cff39fe5

[fdoray, 2017-02-06 22:06:58]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 22:08:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-02-06 22:09:18]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 22:09:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 22:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:34:51]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fdoray, 2017-02-07 13:47:31]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 13:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 13:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 13:55:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[fdoray, 2017-02-07 14:01:04]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 14:01:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 14:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 14:29:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-02-07 14:29:34]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 14:29:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 15:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 15:25:45]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-02-07 15:30:59]

fdoray@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[fdoray, 2017-02-07 15:31:00]

PTAL

[Julia Tuttle, 2017-02-09 16:12:10]

On 2017/02/07 15:31:00, fdoray wrote:
> PTAL

lgtm

[fdoray, 2017-02-09 16:26:10]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org

[fdoray, 2017-02-09 16:26:11]

jochen@: Please review changes in chrome/

[jochen (gone - plz use gerrit), 2017-02-10 09:05:33]

lgtm

[fdoray, 2017-02-10 11:58:03]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-02-10 11:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 12:55:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486727883880380,
"parent_rev": "a9fd36ae04205433ec7ca21aaad3c0540669186c", "commit_rev":
"9f0b47853110ba3becfea5ca2e447588cff39fe5"}

[commit-bot: I haz the power, 2017-02-10 12:56:24]

Description was changed from

==========
Use TaskScheduler in directory_lister.cc.

Instead of taking an external TaskRunner, post directly to
TaskScheduler. This changes removes a call to the deprecated
WorkerPool::GetTaskRunner method.

The following traits are used to post to TaskScheduler:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

to

==========
Use TaskScheduler in directory_lister.cc.

Instead of taking an external TaskRunner, post directly to
TaskScheduler. This changes removes a call to the deprecated
WorkerPool::GetTaskRunner method.

The following traits are used to post to TaskScheduler:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2682523002
Cr-Commit-Position: refs/heads/master@{#449599}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f0b47853110ba3becfea5ca2e44...
==========

[commit-bot: I haz the power, 2017-02-10 12:56:25]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9f0b47853110ba3becfea5ca2e44...