Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2682523002: Use TaskScheduler in directory_lister.cc. (Closed)
Patch Set: remove ScopedTaskScheduler from TokenBindingURLRequestTest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_file_dir_job_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index fa6282d0c94f3805cc4c80d0bea7f0c497a3450c..3ce5e64bdec223e0bc8a362bd2a9593e492302a1 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -777,7 +777,9 @@ class OCSPErrorTestDelegate : public TestDelegate {
// Inherit PlatformTest since we require the autorelease pool on Mac OS X.
class URLRequestTest : public PlatformTest {
public:
- URLRequestTest() : default_context_(true) {
+ URLRequestTest()
+ : scoped_task_scheduler_(base::MessageLoop::current()),
+ default_context_(true) {
default_context_.set_network_delegate(&default_network_delegate_);
default_context_.set_net_log(&net_log_);
job_factory_impl_ = new URLRequestJobFactoryImpl();
@@ -824,6 +826,9 @@ class URLRequestTest : public PlatformTest {
return protocol_handler_;
}
+ private:
+ base::test::ScopedTaskScheduler scoped_task_scheduler_;
+
protected:
TestNetLog net_log_;
TestNetworkDelegate default_network_delegate_; // Must outlive URLRequest.
@@ -3450,8 +3455,7 @@ class TestSSLConfigService : public SSLConfigService {
#if !defined(OS_IOS)
class TokenBindingURLRequestTest : public URLRequestTestHTTP {
public:
- TokenBindingURLRequestTest()
- : scoped_task_scheduler_(base::MessageLoop::current()) {}
+ TokenBindingURLRequestTest() = default;
void SetUp() override {
default_context_.set_ssl_config_service(
@@ -3463,8 +3467,6 @@ class TokenBindingURLRequestTest : public URLRequestTestHTTP {
}
protected:
- // Required by ChannelIDService.
- base::test::ScopedTaskScheduler scoped_task_scheduler_;
std::unique_ptr<ChannelIDService> channel_id_service_;
};
« no previous file with comments | « net/url_request/url_request_file_dir_job_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698