Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2682503002: DevTools: Regex checkbox was missing from filter bars (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
lushnikov
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

DevTools: Regex checkbox was missing from filter bars BUG=686365 Review-Url: https://codereview.chromium.org/2659303002 Cr-Commit-Position: refs/heads/master@{#447047} (cherry picked from commit bae041fd1b08355c53f05729bc384ecae48cb986) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2682503002 Cr-Commit-Position: refs/branch-heads/2987@{#350} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7e51624a7bd1c7826b723f7e168e55fe4c1ec479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-06 21:23:57 UTC) #2
lushnikov
lgtm
3 years, 10 months ago (2017-02-06 21:48:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682503002/1
3 years, 10 months ago (2017-02-06 21:49:24 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-06 21:49:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682503002/1
3 years, 10 months ago (2017-02-06 22:28:53 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:30:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e51624a7bd1c7826b723f7e168e...

Powered by Google App Engine
This is Rietveld 408576698