Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2659303002: DevTools: Regex checkbox was missing from filter bars (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/devtools@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Regex checkbox was missing from filter bars BUG=686365 Review-Url: https://codereview.chromium.org/2659303002 Cr-Commit-Position: refs/heads/master@{#447047} Committed: https://chromium.googlesource.com/chromium/src/+/bae041fd1b08355c53f05729bc384ecae48cb986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
einbinder
ptal
3 years, 10 months ago (2017-01-30 16:23:13 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-01-30 18:19:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659303002/1
3 years, 10 months ago (2017-01-30 18:19:50 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:11:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bae041fd1b08355c53f05729bc38...

Powered by Google App Engine
This is Rietveld 408576698