Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2695453002: Generalize DeclarationBuilder.resolveTypes. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -95 lines) Patch
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 2 chunks +2 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/dynamic_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/function_type_alias_builder.dart View 2 chunks +2 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/invalid_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/named_mixin_application_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_variable_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 2 chunks +11 lines, -19 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
Ends the journey started in CL 2672993003.
3 years, 10 months ago (2017-02-10 20:38:38 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-10 23:17:33 UTC) #3
ahe
3 years, 10 months ago (2017-02-13 15:02:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76ad92e5addf0e0b0d03cf5a90efc22f0944226d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698