Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2682293002:
Add desktop UI for the subresource filter content setting. (Closed)
|
Created:
3 years, 10 months ago by melandory Modified:
3 years, 7 months ago CC:
chromium-reviews, dbeam+watch-options_chromium.org, msramek+watch_chromium.org, michaelpg+watch-options_chromium.org, subresource-filter-reviews_chromium.org, raymes+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, markusheintz_, srahim+watch_chromium.org, dschuyler Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd desktop UI for the subresource filter content setting.
Added option on chrome://settings/content to toggle subresource filter on a
global or per-site basis.
BUG=689487, 689992
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2682293002
Cr-Commit-Position: refs/heads/master@{#460402}
Committed: https://chromium.googlesource.com/chromium/src/+/7be36d31cf92f725808f0260e565ed093541505f
Patch Set 1 #Patch Set 2 : guard appearance in settings via feature #Patch Set 3 : md settings #Patch Set 4 : . #
Total comments: 8
Patch Set 5 : comments #
Total comments: 15
Patch Set 6 : comments #
Total comments: 2
Patch Set 7 : cs_ui #
Total comments: 2
Messages
Total messages: 105 (79 generated)
Description was changed from ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 ========== to ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
melandory@chromium.org changed reviewers: + raymes@chromium.org
raymes@, PTAL at changes in chrome/browser/ui/website_settings/website_settings.cc chrome/browser/ui/website_settings/website_settings_ui.cc
raymes@, PTAL at changes in chrome/browser/ui/website_settings/website_settings.cc chrome/browser/ui/website_settings/website_settings_ui.cc
melandory@chromium.org changed reviewers: + oshima@chromium.org
oshima@chromium.org: Please review changes in chrome/app/scheme
melandory@chromium.org changed reviewers: + dbeam@chromium.org
dbeam@chromium.org: Please review changes in chrome/browser/resources and chrome/browser/webui
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/02/09 15:31:30, melandory wrote: > mailto:dbeam@chromium.org: Please review changes in > > chrome/browser/resources > and > chrome/browser/webui This is your UX writer here. Are the messages added in this CL going to be localized? If so, I anticipate translators will need more information for "Subresource filter" and "New audio rendering mixing strategy". Can you explain what the settings are, and I can help to write a more complete message description?
> This is your UX writer here. Are the messages added in this CL going to be > localized? If so, I anticipate translators will need more information for > "Subresource filter" and "New audio rendering mixing strategy". Can you explain > what the settings are, and I can help to write a more complete message > description? Note that both the content setting and UI pieces are still behind a flag. We would like to get a head start with the engineering work while the strings are being finalized. Is there a way to indicate in the resource files that we don't want localization yet?
c/a/theme lgtm
Patchset #5 (id:100001) has been deleted
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
don't change code in /options/, it's deprecated and going to be deleted soon instead, see: chrome/browser/resources/settings chrome/browser/ui/webui/settings for the new, Material Design version that will replace it
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Patchset #4 (id:120001) has been deleted
Patchset #2 (id:20001) has been deleted
PTAL On 2017/02/11 23:05:16, Dan Beam wrote: > don't change code in /options/, it's deprecated and going to be deleted soon Done > > instead, see: > > chrome/browser/resources/settings > chrome/browser/ui/webui/settings > > for the new, Material Design version that will replace it Done
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:180001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #6 (id:220001) has been deleted
Patchset #5 (id:200001) has been deleted
Patchset #4 (id:160001) has been deleted
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: + tommycli@chromium.org
+tommycli@ as a reviewer for settings/
dbeam@chromium.org changed reviewers: - dbeam@chromium.org
https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:380: <template is="dom-if" route-path="/content/subresourceFilter" no-search> also strange indent https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:391: </template> strange indent. https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:393: route-path="/content/unsandboxedPlugins" no-search> Can you double check this dom-if? It seems to link isSubresourceFilterAvailable to unsandboxedPlugins, which doesn't make sense. https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/ui/webu... File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/ui/webu... chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1773: "isSubresourceFilterVisible", All our other switches are named: "showFooBar" or "enableFooBar", so I suggest you change "isSubresourceFilterAvailable" to something like "enableSafeBrowsingSubresourceFilter".
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Patchset #6 (id:280001) has been deleted
Patchset #5 (id:260001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:380: <template is="dom-if" route-path="/content/subresourceFilter" no-search> On 2017/03/13 19:17:01, tommycli wrote: > also strange indent Done. https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:391: </template> On 2017/03/13 19:17:01, tommycli wrote: > strange indent. Done. https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:393: route-path="/content/unsandboxedPlugins" no-search> On 2017/03/13 19:17:01, tommycli wrote: > Can you double check this dom-if? It seems to link isSubresourceFilterAvailable > to unsandboxedPlugins, which doesn't make sense. Done. https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/ui/webu... File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/2682293002/diff/240001/chrome/browser/ui/webu... chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1773: "isSubresourceFilterVisible", On 2017/03/13 19:17:01, tommycli wrote: > All our other switches are named: "showFooBar" or "enableFooBar", so I suggest > you change "isSubresourceFilterAvailable" to something like > "enableSafeBrowsingSubresourceFilter". Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
friendly ping
lgtm except below https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:401: <template is="dom-if" if="enableSafeBrowsingSubresourceFilter_" Hey did you mean if="[[enableSafeBrowsingSubresourceFilter_]]"?
melandory@chromium.org changed reviewers: + msw@chromium.org
msw@chromium.org: Please review changes in chrome/browser/ui
Just nits and a question about the new strings. https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14742: + nit: remove extra blank line? https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14746: + <message name="IDS_SUBRESOURCE_FILTER_ALLOW_RADIO" desc="A radio button on the Content Settings dialog to allow to use subresource filter."> nit: "to allow subresource filter use" https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14747: + Allow the Subrsource Filter to perform filtering These strings are a little vague; I have no idea what a subresource filter is; will our users? Has PM/UX approved these strings? https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14749: + <message name="IDS_SUBRESOURCE_FILTER_BLOCK_RADIO" desc="A radio button on the Content Settings dialog to block subresource filter on all sites."> nit: "to allow subresource filter use" https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14750: + Doesn't allow Subresource Filter to perform filtering nit: "Do not allow the"...? https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14751: + </message> nit: indent https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/ui/page... File chrome/browser/ui/page_info/website_settings.cc (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/ui/page... chrome/browser/ui/page_info/website_settings.cc:114: CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER}; nit: formatting (trailing comma, closing brace on next line)
https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14742: + On 2017/03/23 18:18:08, msw wrote: > nit: remove extra blank line? Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14746: + <message name="IDS_SUBRESOURCE_FILTER_ALLOW_RADIO" desc="A radio button on the Content Settings dialog to allow to use subresource filter."> On 2017/03/23 18:18:08, msw wrote: > nit: "to allow subresource filter use" Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14749: + <message name="IDS_SUBRESOURCE_FILTER_BLOCK_RADIO" desc="A radio button on the Content Settings dialog to block subresource filter on all sites."> On 2017/03/23 18:18:08, msw wrote: > nit: "to allow subresource filter use" Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14750: + Doesn't allow Subresource Filter to perform filtering On 2017/03/23 18:18:08, msw wrote: > nit: "Do not allow the"...? Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/app/generated_r... chrome/app/generated_resources.grd:14751: + </message> On 2017/03/23 18:18:08, msw wrote: > nit: indent Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:401: <template is="dom-if" if="enableSafeBrowsingSubresourceFilter_" On 2017/03/22 16:10:34, tommycli wrote: > Hey did you mean if="[[enableSafeBrowsingSubresourceFilter_]]"? Done. https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/ui/page... File chrome/browser/ui/page_info/website_settings.cc (right): https://codereview.chromium.org/2682293002/diff/300001/chrome/browser/ui/page... chrome/browser/ui/page_info/website_settings.cc:114: CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER}; On 2017/03/23 18:18:08, msw wrote: > nit: formatting (trailing comma, closing brace on next line) Done.
lgtm with a spelling nit https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... chrome/app/generated_resources.grd:14746: + Allow the Subrsource Filter to perform filtering nit: "Subresource" spelling
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... chrome/app/generated_resources.grd:14746: + Allow the Subrsource Filter to perform filtering On 2017/03/23 20:50:37, msw wrote: > nit: "Subresource" spelling Done.
https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2682293002/diff/320001/chrome/app/generated_r... chrome/app/generated_resources.grd:14746: + Allow the Subrsource Filter to perform filtering On 2017/03/23 20:50:37, msw wrote: > nit: "Subresource" spelling Done.
The CQ bit was checked by melandory@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org, tommycli@chromium.org, msw@chromium.org Link to the patchset: https://codereview.chromium.org/2682293002/#ps340001 (title: "cs_ui")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 340001, "attempt_start_ts": 1490798764079270,
"parent_rev": "92b1af1d8a6162a1a9638d02c3485363ffb60abd", "commit_rev":
"7be36d31cf92f725808f0260e565ed093541505f"}
Message was sent while issue was closed.
Description was changed from ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add desktop UI for the subresource filter content setting. Added option on chrome://settings/content to toggle subresource filter on a global or per-site basis. BUG=689487, 689992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2682293002 Cr-Commit-Position: refs/heads/master@{#460402} Committed: https://chromium.googlesource.com/chromium/src/+/7be36d31cf92f725808f0260e565... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:340001) as https://chromium.googlesource.com/chromium/src/+/7be36d31cf92f725808f0260e565...
Message was sent while issue was closed.
csharrison@chromium.org changed reviewers: + csharrison@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2682293002/diff/340001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/340001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:409: category="{{ContentSettingsTypes.SUBRESOURCE_FITER}}"> Looks like SUBRESOURCE_FILTER is misspelled here?
Message was sent while issue was closed.
dschuyler@chromium.org changed reviewers: + dschuyler@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2682293002/diff/340001/chrome/browser/resourc... File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2682293002/diff/340001/chrome/browser/resourc... chrome/browser/resources/settings/privacy_page/privacy_page.html:409: category="{{ContentSettingsTypes.SUBRESOURCE_FITER}}"> On 2017/04/28 23:23:02, Charlie (ooo-ish until may 2) wrote: > Looks like SUBRESOURCE_FILTER is misspelled here? I agree, I'll make a fix for this. https://codereview.chromium.org/2851933002/ |
