chrome/browser/resources/settings/site_settings_page/site_settings_page.html - Issue 2682293002: Add desktop UI for the subresource filter content setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2682293002: Add desktop UI for the subresource filter content setting. (Closed)

Patch Set: cs_ui Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/privacy_page/privacy_page.html ('K') | « chrome/browser/resources/settings/site_settings/constants.js ('k') | chrome/browser/resources/settings/site_settings_page/site_settings_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

index 113de7c187ed12f5abb38da016b0d3f762f3bfcd..a4b27a204efb5a7e343f5e4ba431ffbd61db9ecc 100644

--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

@@ -276,6 +276,26 @@

aria-label="$i18n{siteSettingsMidiDevices}"

aria-describedby="midiDevicesSecondary"></button>

</div>

+ <template is="dom-if" if="[[enableSafeBrowsingSubresourceFilter_]]">

+ <div class="settings-box two-line"

+ category$="[[ContentSettingsTypes.SUBRESOURCE_FILTER]]"

+ data-route="SITE_SETTINGS_SUBRESOURCE_FILTER" on-tap="onTapNavigate_"

+ actionable>

+ <iron-icon icon="cr:open-in-new"></iron-icon>

+ <div class="middle">

+ $i18n{siteSettingsSubresourceFilter}

+ <div class="secondary" id="subresourceFilterSecondary">

+ [[defaultSettingLabel_(

+ default_.subresourceFilter,

+ '$i18nPolymer{siteSettingsSubresourceFilterBlock}',

+ '$i18nPolymer{siteSettingsSubresourceFilterAllow}')]]

+ </div>

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-label="$i18n{siteSettingsSubresourceFilter}"

+ aria-describedby="subresourceFilterSecondary"></button>

+ </div>

+ </template>

<div class="settings-box" category$="[[ContentSettingsTypes.ZOOM_LEVELS]]"

data-route="SITE_SETTINGS_ZOOM_LEVELS"

on-tap="onTapNavigate_" actionable>