Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2682193002: Convert NavigationController unit and browser tests to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert NavigationController unit and browser tests to use the new navigation callbacks. BUG=682002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2682193002 Cr-Commit-Position: refs/heads/master@{#449205} Committed: https://chromium.googlesource.com/chromium/src/+/a0e5e40a1f939430bf21f60045bdf5bc28100f97

Patch Set 1 #

Total comments: 10

Patch Set 2 : review comments #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -199 lines) Patch
M content/browser/frame_host/interstitial_page_navigator_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 58 chunks +166 lines, -162 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 20 chunks +50 lines, -33 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 4 chunks +8 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 4 chunks +5 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (18 generated)
jam
3 years, 10 months ago (2017-02-08 22:32:54 UTC) #5
nasko
LGTM with a few comments and nits. https://codereview.chromium.org/2682193002/diff/1/content/browser/frame_host/interstitial_page_navigator_impl.cc File content/browser/frame_host/interstitial_page_navigator_impl.cc (right): https://codereview.chromium.org/2682193002/diff/1/content/browser/frame_host/interstitial_page_navigator_impl.cc#newcode53 content/browser/frame_host/interstitial_page_navigator_impl.cc:53: NAVIGATION_TYPE_UNKNOWN, Interstitials ...
3 years, 10 months ago (2017-02-09 00:29:12 UTC) #8
jam
https://codereview.chromium.org/2682193002/diff/1/content/browser/frame_host/interstitial_page_navigator_impl.cc File content/browser/frame_host/interstitial_page_navigator_impl.cc (right): https://codereview.chromium.org/2682193002/diff/1/content/browser/frame_host/interstitial_page_navigator_impl.cc#newcode53 content/browser/frame_host/interstitial_page_navigator_impl.cc:53: NAVIGATION_TYPE_UNKNOWN, On 2017/02/09 00:29:11, nasko (very slow) wrote: > ...
3 years, 10 months ago (2017-02-09 01:15:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682193002/20001
3 years, 10 months ago (2017-02-09 01:15:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/150089) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-09 01:17:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682193002/40001
3 years, 10 months ago (2017-02-09 01:27:25 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 05:21:35 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a0e5e40a1f939430bf21f60045bd...

Powered by Google App Engine
This is Rietveld 408576698