Convert NavigationController unit and browser tests to use the new navigation callbacks.

content/browser/frame_host/interstitial_page_navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_navigator_impl.h"
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigator_delegate.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
@@ skipping 32 matching lines @@
                                    0,      // pending_nav_entry_id
                                    false)  // started_in_context_menu
       );
 }
 
 void InterstitialPageNavigatorImpl::DidNavigate(
     RenderFrameHostImpl* render_frame_host,
     const FrameHostMsg_DidCommitProvisionalLoad_Params& input_params,
     std::unique_ptr<NavigationHandleImpl> navigation_handle) {
   navigation_handle->DidCommitNavigation(input_params, false, GURL(),
+                                         NAVIGATION_TYPE_UNKNOWN,

[nasko, 2017/02/09 00:29:11]

Interstitials navigate to a new page, so it seems more fitting to use
NAVIGATION_TYPE_NEW_PAGE.

[jam, 2017/02/09 01:15:03]

Done.

                                          render_frame_host);
   navigation_handle.reset();
 
   // TODO(nasko): Move implementation here, but for the time being call out
   // to the interstitial page code.
   interstitial_->DidNavigate(render_frame_host->render_view_host(),
                              input_params);
 }
 
 }  // namespace content