Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2682043002: Expose thumbnails of pages to iOS share extensions. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Expose thumbnails of pages to iOS share extensions. This CLs implements UIActivityItemSource's |activityViewController:thumbnailImageForActivityType:suggestedSize:|. Also: -factor out of the BVC the creation of ShareToData. -remove unused UIActivityURLSource. -fix ui/base/test/ios/OWNERS (broken by https://codereview.chromium.org/1885043012 ) TEST=Share a page from Chrome iOS to the Chrome iOS extension. A thumbnail of the page should be shown. BUG=686049 Review-Url: https://codereview.chromium.org/2645653003 Cr-Commit-Position: refs/heads/master@{#447977} (cherry picked from commit 4a8cf9449a9df503e1993433249a9e6923b5d810) Review-Url: https://codereview.chromium.org/2682043002 . Cr-Commit-Position: refs/branch-heads/2987@{#383} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a2186c11d838c7a5633197018ec3727360827623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -151 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/BUILD.gn View 5 chunks +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm View 7 chunks +34 lines, -24 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h View 2 chunks +9 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/chrome_activity_item_source.mm View 4 chunks +13 lines, -50 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.mm View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator_unittest.mm View 1 chunk +62 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/share_to_data.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/share_to_data.mm View 3 chunks +9 lines, -27 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/share_to_data_builder.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/share_to_data_builder.mm View 1 chunk +41 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 3 chunks +3 lines, -23 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 2 chunks +25 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.h View 1 chunk +8 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ui_util_unittest.mm View 1 chunk +27 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util_unittest.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M ui/base/test/ios/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
A ui/base/test/ios/ui_image_test_utils.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/base/test/ios/ui_image_test_utils.mm View 1 chunk +48 lines, -0 lines 0 comments Download
A ui/base/test/ios/ui_image_test_utils_unittest.mm View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jif
3 years, 10 months ago (2017-02-08 09:47:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2186c11d838c7a5633197018ec3727360827623.

Powered by Google App Engine
This is Rietveld 408576698