Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1885043012: Remove ui/base/ios (Closed)

Created:
4 years, 8 months ago by Jackie Quinn
Modified:
4 years, 8 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@context_menu_copy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ui/base/ios The contents of ui/base/ios, CRUContextMenuController and CRUContextMenuHolder were moved to ios/chrome/browser/ui/context_menu. This is part 3 of 3. BUG=604727 Committed: https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c Cr-Commit-Position: refs/heads/master@{#389118}

Patch Set 1 #

Patch Set 2 : Remove CRWContextMenuProvider #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -395 lines) Patch
M ios/web/web_state/ui/crw_context_menu_provider.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D ui/base/ios/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/base/ios/cru_context_menu_controller.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/base/ios/cru_context_menu_controller.mm View 1 chunk +0 lines, -151 lines 0 comments Download
D ui/base/ios/cru_context_menu_controller_unittest.mm View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/base/ios/cru_context_menu_holder.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/base/ios/cru_context_menu_holder.mm View 1 chunk +0 lines, -74 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Jackie Quinn
4 years, 8 months ago (2016-04-22 00:14:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885043012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885043012/20001
4 years, 8 months ago (2016-04-22 00:17:34 UTC) #5
Nico
do you need to remove the files from any BUILD.gn files too? rs-lgtm if sdefresne ...
4 years, 8 months ago (2016-04-22 00:55:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 01:18:30 UTC) #8
Jackie Quinn
On 2016/04/22 00:55:09, Nico wrote: > do you need to remove the files from any ...
4 years, 8 months ago (2016-04-22 03:23:13 UTC) #9
sdefresne
lgtm
4 years, 8 months ago (2016-04-22 10:08:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885043012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885043012/20001
4 years, 8 months ago (2016-04-22 15:42:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 15:46:54 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1a5768d761d650a394bbea1bb8af41760f7417c
Cr-Commit-Position: refs/heads/master@{#389118}

Powered by Google App Engine
This is Rietveld 408576698