ChromeOS OOBE: Add ARIA-labels for OOBE screens.

ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG=682145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2681923005
Cr-Commit-Position: refs/heads/master@{#449162}
Committed: https://chromium.googlesource.com/chromium/src/+/824235e7763820cb2a81c1d09573a0aa335d4ff8

[Alexander Alekseev, 2017-02-08 04:37:29]

Description was changed from

==========
ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG=682145
==========

to

==========
ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG=682145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-02-08 04:39:35]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Alexander Alekseev, 2017-02-08 04:39:35]

Please review.

[Alexander Alekseev, 2017-02-08 04:39:41]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 04:39:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 04:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 04:41:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Alexander Alekseev, 2017-02-08 05:37:58]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 05:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 06:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 06:21:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Alekseev, 2017-02-08 19:04:02]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 19:05:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-02-08 20:47:53]

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:84:
aria-label="[[formatMessage_(languageDropdownLabel_, currentLanguage)]]"
Fix wrapping ( you can separate parameters on different lines, e.g.:

                aria-label="[[formatMessage_(languageDropdownLabel_,
                    currentLanguage)]]">

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:95:
aria-label="[[formatMessage_(keyboardDropdownLabel_, currentKeyboard)]]"
wrapping

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:136: },
I don't think you need this, you can embed string literals in the html, i.e.
'languageDropdownLabel'.

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:144: },
ditto

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:25:
aria-label="[[formatMessage_(languageButtonLabel_, currentLanguage)]]"
wrap + ('languageButtonLabel', currentLanguage)

[commit-bot: I haz the power, 2017-02-08 21:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:06:09]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-02-08 21:43:53]

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:84:
aria-label="[[formatMessage_(languageDropdownLabel_, currentLanguage)]]"
On 2017/02/08 20:47:53, stevenjb wrote:
> Fix wrapping ( you can separate parameters on different lines, e.g.:
> 
>                 aria-label="[[formatMessage_(languageDropdownLabel_,
>                     currentLanguage)]]">

Done.

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:95:
aria-label="[[formatMessage_(keyboardDropdownLabel_, currentKeyboard)]]"
On 2017/02/08 20:47:53, stevenjb wrote:
> wrapping

Done.

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:136: },
On 2017/02/08 20:47:53, stevenjb wrote:
> I don't think you need this, you can embed string literals in the html, i.e.
> 'languageDropdownLabel'.

Done.

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:144: },
On 2017/02/08 20:47:53, stevenjb wrote:
> ditto

Done.

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2681923005/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:25:
aria-label="[[formatMessage_(languageButtonLabel_, currentLanguage)]]"
On 2017/02/08 20:47:53, stevenjb wrote:
> wrap + ('languageButtonLabel', currentLanguage)

Done.

[Alexander Alekseev, 2017-02-08 21:44:02]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 21:44:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:22:29]

Dry run: This issue passed the CQ dry run.

[stevenjb (google-dont-use), 2017-02-08 23:53:49]

stevenjb@google.com changed reviewers:
+ stevenjb@google.com

[stevenjb (google-dont-use), 2017-02-08 23:53:50]

lgtm

[Alexander Alekseev, 2017-02-09 00:25:44]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:26:27]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[stevenjb, 2017-02-09 00:32:22]

lgtm

[Alexander Alekseev, 2017-02-09 00:36:02]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:36:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:43:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486600562537920,
"parent_rev": "c33888d40c74c5568c85d4c8228831c70d7a7442", "commit_rev":
"824235e7763820cb2a81c1d09573a0aa335d4ff8"}

[commit-bot: I haz the power, 2017-02-09 00:43:55]

Description was changed from

==========
ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG=682145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: Add ARIA-labels for OOBE screens.

BUG=682145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2681923005
Cr-Commit-Position: refs/heads/master@{#449162}
Committed:
https://chromium.googlesource.com/chromium/src/+/824235e7763820cb2a81c1d09573...
==========

[commit-bot: I haz the power, 2017-02-09 00:43:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/824235e7763820cb2a81c1d09573...