SVGTransformList.consolidate() should return null on an empty list

SVGTransformList.consolidate() should return null on an empty list

SVGTransformList.consolidate() returns an SVGTransform with type
"unknown", which is an invalid object that other parts of the code
couldn't cope with. The specification:

 https://svgwg.org/svg2-draft/coords.html#__svg__SVGTransformList__consolidate

say that 'null' should be returned in this case though, so do that
instead.

Rewrite svg/dom/SVGTransformList-empty-list-consolidation.html to use
actually assert this part of the contract, and also convert it use
testharness.js while at it.

BUG=688306, 688303
Review-Url: https://codereview.chromium.org/2681803004
Cr-Commit-Position: refs/heads/master@{#448994}
Committed: https://chromium.googlesource.com/chromium/src/+/d3173fb3e213e658abf34667f130b55b6baac395

[fs, 2017-02-08 12:28:33]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 12:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-08 12:32:04]

Description was changed from

==========
SVGTransformList.consolidate() should return null on an empty list

As speced:

 https://svgwg.org/svg2-draft/coords.html#__svg__SVGTransformList__consolidate

Before this CL we were returning an SVGTransform with type "unknown",
which is an invalid object that other parts of the code couldn't cope
with.

BUG=688306, 688303
==========

to

==========
SVGTransformList.consolidate() should return null on an empty list

SVGTransformList.consolidate() returns an SVGTransform with type
"unknown", which is an invalid object that other parts of the code
couldn't cope with. The specification:

 https://svgwg.org/svg2-draft/coords.html#__svg__SVGTransformList__consolidate

say that 'null' should be returned in this case though, so do that
instead.

Rewrite svg/dom/SVGTransformList-empty-list-consolidation.html to use
actually assert this part of the contract, and also convert it use
testharness.js while at it.

BUG=688306, 688303
==========

[fs, 2017-02-08 12:46:35]

fs@opera.com changed reviewers:
+ sigbjornf@opera.com

[fs, 2017-02-08 12:46:36]

TC (svgtransformlist-empty-consolidate-and-initialize-crash.html) derived from
looking at the stacktrace from the bug + analysis. Crashes with the same stack
(top 10 frames or so), so hopefully it's issue we're looking for...

[sof, 2017-02-08 13:44:07]

lgtm

[commit-bot: I haz the power, 2017-02-08 14:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 14:43:59]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-08 14:50:28]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-02-08 14:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 14:55:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486565428223120, "parent_rev":
"e398e7fd334c08a2cfb805b25b0792fb15e674d3", "commit_rev":
"d3173fb3e213e658abf34667f130b55b6baac395"}

[commit-bot: I haz the power, 2017-02-08 14:55:40]

Description was changed from

==========
SVGTransformList.consolidate() should return null on an empty list

SVGTransformList.consolidate() returns an SVGTransform with type
"unknown", which is an invalid object that other parts of the code
couldn't cope with. The specification:

 https://svgwg.org/svg2-draft/coords.html#__svg__SVGTransformList__consolidate

say that 'null' should be returned in this case though, so do that
instead.

Rewrite svg/dom/SVGTransformList-empty-list-consolidation.html to use
actually assert this part of the contract, and also convert it use
testharness.js while at it.

BUG=688306, 688303
==========

to

==========
SVGTransformList.consolidate() should return null on an empty list

SVGTransformList.consolidate() returns an SVGTransform with type
"unknown", which is an invalid object that other parts of the code
couldn't cope with. The specification:

 https://svgwg.org/svg2-draft/coords.html#__svg__SVGTransformList__consolidate

say that 'null' should be returned in this case though, so do that
instead.

Rewrite svg/dom/SVGTransformList-empty-list-consolidation.html to use
actually assert this part of the contract, and also convert it use
testharness.js while at it.

BUG=688306, 688303

Review-Url: https://codereview.chromium.org/2681803004
Cr-Commit-Position: refs/heads/master@{#448994}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3173fb3e213e658abf34667f130...
==========

[commit-bot: I haz the power, 2017-02-08 14:55:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3173fb3e213e658abf34667f130...