third_party/WebKit/Source/core/svg/SVGTransformList.cpp - Issue 2681803004: SVGTransformList.consolidate() should return null on an empty list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTransformList.cpp

Issue 2681803004: SVGTransformList.consolidate() should return null on an empty list (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTransformList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

index 016cf90f1861c0caeaa93419fb12f1ddb0f53e43..434641ee9c4c40eb88faf44de5877b52bb4a2dcd 100644

--- a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

@@ -43,7 +43,7 @@ SVGTransformList::~SVGTransformList() {}

SVGTransform* SVGTransformList::consolidate() {

AffineTransform matrix;

if (!concatenate(matrix))

- return SVGTransform::create();

+ return nullptr;

return initialize(SVGTransform::create(matrix));

}