Since SafeBrowsingNavigationObserverManager cleans up navigation events every two minutes, if downl…

Since SafeBrowsingNavigationObserverManager cleans up navigation events every two minutes, if downloading a file takes more than 2 minutes, we'll get nothing from the attribution logic. Therefore, this CL moves the download attribution logic to after download url checking (before download starts).

This CL also changes the way of how referrer chain is constructed.
Instead of putting referrer entries in a temporary vector, I put
them directly into a RepeatedPtrField<ReferrerChainEntry> to avoid
extra copying/moving operations. This should mitigate the out-of
-memory issue.

BUG=683299, 676675
Review-Url: https://codereview.chromium.org/2647323004
Cr-Commit-Position: refs/heads/master@{#446761}
(cherry picked from commit 20d16215e1bd867da6a23887046f4d6894222c00)

Review-Url: https://codereview.chromium.org/2681783003 .
Cr-Commit-Position: refs/branch-heads/2987@{#375}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/0d14f396060bdb6639dba6664ee77fe2f2e3e423

[Jialiu Lin, 2017-02-08 01:45:12]

Description was changed from

==========
Since SafeBrowsingNavigationObserverManager cleans up navigation events every
two minutes, if downloading a file takes more than 2 minutes, we'll get nothing
from the attribution logic. Therefore, this CL moves the download attribution
logic to after download url checking (before download starts).

This CL also changes the way of how referrer chain is constructed.
Instead of putting referrer entries in a temporary vector, I put
them directly into a RepeatedPtrField<ReferrerChainEntry> to avoid
extra copying/moving operations. This should mitigate the out-of
-memory issue.

BUG=683299,676675

Review-Url: https://codereview.chromium.org/2647323004
Cr-Commit-Position: refs/heads/master@{#446761}
(cherry picked from commit 20d16215e1bd867da6a23887046f4d6894222c00)
==========

to

==========
Since SafeBrowsingNavigationObserverManager cleans up navigation events every
two minutes, if downloading a file takes more than 2 minutes, we'll get nothing
from the attribution logic. Therefore, this CL moves the download attribution
logic to after download url checking (before download starts).

This CL also changes the way of how referrer chain is constructed.
Instead of putting referrer entries in a temporary vector, I put
them directly into a RepeatedPtrField<ReferrerChainEntry> to avoid
extra copying/moving operations. This should mitigate the out-of
-memory issue.

BUG=683299,676675

Review-Url: https://codereview.chromium.org/2647323004
Cr-Commit-Position: refs/heads/master@{#446761}
(cherry picked from commit 20d16215e1bd867da6a23887046f4d6894222c00)

Review-Url: https://codereview.chromium.org/2681783003 .
Cr-Commit-Position: refs/branch-heads/2987@{#375}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d14f396060bdb6639dba6664ee7...
==========

[Jialiu Lin, 2017-02-08 01:45:13]

Committed patchset #1 (id:1) manually as
0d14f396060bdb6639dba6664ee77fe2f2e3e423.