Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc

Issue 2681783003: Since SafeBrowsingNavigationObserverManager cleans up navigation events every two minutes, if downl… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
index ed9ffecdd5a48f8234fd3792ee458abd4124dcc0..e3fd42ff83cea1da6e536d96c8882695d0096b1f 100644
--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
@@ -75,6 +75,16 @@ static const double kUserGestureTTLInSecond = 1.0;
// expired. So we clean up these navigation footprints every 2 minutes.
static const double kNavigationFootprintTTLInSecond = 120.0;
+ReferrerChainData::ReferrerChainData(
+ std::unique_ptr<ReferrerChain> referrer_chain)
+ : referrer_chain_(std::move(referrer_chain)) {}
+
+ReferrerChainData::~ReferrerChainData() {}
+
+ReferrerChain* ReferrerChainData::GetReferrerChain() {
+ return referrer_chain_.get();
+}
+
// static
const base::Feature
SafeBrowsingNavigationObserverManager::kDownloadAttribution {
@@ -433,28 +443,27 @@ void SafeBrowsingNavigationObserverManager::AddToReferrerChain(
ReferrerChain* referrer_chain,
NavigationEvent* nav_event,
ReferrerChainEntry::URLType type) {
- std::unique_ptr<ReferrerChainEntry> referrer_chain_entry =
- base::MakeUnique<ReferrerChainEntry>();
- referrer_chain_entry->set_url(nav_event->destination_url.spec());
- referrer_chain_entry->set_type(type);
+ ReferrerChainEntry referrer_chain_entry;
+ referrer_chain_entry.set_url(nav_event->destination_url.spec());
+ referrer_chain_entry.set_type(type);
auto ip_it = host_to_ip_map_.find(nav_event->destination_url.host());
if (ip_it != host_to_ip_map_.end()) {
for (ResolvedIPAddress entry : ip_it->second) {
- referrer_chain_entry->add_ip_addresses(entry.ip);
+ referrer_chain_entry.add_ip_addresses(entry.ip);
}
}
// Since we only track navigation to landing referrer, we will not log the
// referrer of the landing referrer page.
if (type != ReferrerChainEntry::LANDING_REFERRER) {
- referrer_chain_entry->set_referrer_url(nav_event->source_url.spec());
- referrer_chain_entry->set_referrer_main_frame_url(
+ referrer_chain_entry.set_referrer_url(nav_event->source_url.spec());
+ referrer_chain_entry.set_referrer_main_frame_url(
nav_event->source_main_frame_url.spec());
}
- referrer_chain_entry->set_is_retargeting(nav_event->source_tab_id !=
+ referrer_chain_entry.set_is_retargeting(nav_event->source_tab_id !=
nav_event->target_tab_id);
- referrer_chain_entry->set_navigation_time_msec(
+ referrer_chain_entry.set_navigation_time_msec(
nav_event->last_updated.ToJavaTime());
- referrer_chain->push_back(std::move(referrer_chain_entry));
+ referrer_chain->Add()->Swap(&referrer_chain_entry);
}
void SafeBrowsingNavigationObserverManager::GetRemainingReferrerChain(
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698