Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2681773002: [ObjC ARC] Converts ios/chrome/browser/ui/reader_mode:reader_mode to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/reader_mode:reader_mode to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2681773002 Cr-Commit-Position: refs/heads/master@{#448631} Committed: https://chromium.googlesource.com/chromium/src/+/9e39f46db7d73fcd0aa9262d9ca4377f4b83c5e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M ios/chrome/browser/ui/reader_mode/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reader_mode/reader_mode_controller.mm View 8 chunks +10 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/reader_mode/reader_mode_infobar_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reader_mode/reader_mode_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/reader_mode/reader_mode_view.mm View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lody
Please review, thanks
3 years, 10 months ago (2017-02-07 15:46:04 UTC) #6
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-07 15:52:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681773002/1
3 years, 10 months ago (2017-02-07 15:53:41 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 15:58:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e39f46db7d73fcd0aa9262d9ca4...

Powered by Google App Engine
This is Rietveld 408576698