Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: ios/chrome/browser/ui/reader_mode/reader_mode_view.mm

Issue 2681773002: [ObjC ARC] Converts ios/chrome/browser/ui/reader_mode:reader_mode to ARC. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/reader_mode/reader_mode_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
diff --git a/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm b/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
index 471394af3ed3ea69e8bda6d2fad4a39cd84a66ba..10e886e047fcc8bf53941e0aba0889e1777360c4 100644
--- a/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
+++ b/ios/chrome/browser/ui/reader_mode/reader_mode_view.mm
@@ -4,12 +4,14 @@
#import "ios/chrome/browser/ui/reader_mode/reader_mode_view.h"
-#include "base/mac/objc_property_releaser.h"
-#include "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/dom_distiller/distiller_viewer.h"
#import "ios/chrome/browser/ui/material_components/activity_indicator.h"
#import "ios/third_party/material_components_ios/src/components/ActivityIndicator/src/MaterialActivityIndicator.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
const CGFloat kCloseButtonSize = 40;
const CGFloat kCloseButtonMargin = 10;
@@ -19,11 +21,10 @@ const CGFloat kMinHeight = kMinWidth;
@interface ReaderModeView ()<MDCActivityIndicatorDelegate> {
std::unique_ptr<dom_distiller::DistillerViewer> _viewer;
- base::mac::ObjCPropertyReleaser _propertyReleaser_ReaderModeView;
}
-@property(nonatomic, retain) MDCActivityIndicator* activityIndicator;
+@property(nonatomic, strong) MDCActivityIndicator* activityIndicator;
@property(nonatomic, copy) ProceduralBlock animateOutCompletionBlock;
-@property(nonatomic, retain) UIButton* closeButton;
+@property(nonatomic, strong) UIButton* closeButton;
@end
@@ -37,7 +38,6 @@ const CGFloat kMinHeight = kMinWidth;
delegate:(id<ReaderModeViewDelegate>)delegate {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_ReaderModeView.Init(self, [ReaderModeView class]);
_delegate = delegate;
self.backgroundColor = [UIColor whiteColor];
@@ -45,7 +45,7 @@ const CGFloat kMinHeight = kMinWidth;
self.autoresizingMask =
UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
- _closeButton = [[UIButton buttonWithType:UIButtonTypeRoundedRect] retain];
+ _closeButton = [UIButton buttonWithType:UIButtonTypeRoundedRect];
[_closeButton addTarget:self
action:@selector(close)
forControlEvents:UIControlEventTouchUpInside];
« no previous file with comments | « ios/chrome/browser/ui/reader_mode/reader_mode_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698