Remove kDisableUnifiedMediaPipeline

Remove kDisableUnifiedMediaPipeline

WMPA has been removed and the Unified Media Pipeline has been
in production for many months now. It's safe to remove the
flag to disable the UMP.

BUG=570711, 646312
Review-Url: https://codereview.chromium.org/2681643006
Cr-Commit-Position: refs/heads/master@{#449536}
Committed: https://chromium.googlesource.com/chromium/src/+/87552634f69a29a78a732942ad1313349bd8e93d

[tguilbert, 2017-02-07 22:45:55]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:47:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tguilbert, 2017-02-08 00:22:35]

tguilbert@chromium.org changed reviewers:
+ zqzhang@chromium.org

[tguilbert, 2017-02-08 00:22:36]

Hello, PTAL :)

zqzhang@, can you make sure the changes in
media_session_impl_visibility_browsertest.cc look OK to you? The WMPA tests have
been disabled since last September.

xhwang@, can you review media/*?
I also removed one of your TODO's in RenderFrameImpl and percolated the changes.
LMK if there is a different way this should be handled.

After your reviews, I will add chrome/ and content/ OWNERS.

Thanks!

[tguilbert, 2017-02-08 00:27:54]

Description was changed from

==========
Remove kDisableUnifiedMediaPipeline

//TODO(tguilbert)

BUG=570711
==========

to

==========
Remove kDisableUnifiedMediaPipeline

WMPA has been removed and the Unified Media Pipeline has been
in production for many months now. It's safe to remove the
flag to disable the UMP.

BUG=570711, 646312
==========

[tguilbert, 2017-02-08 00:27:54]

tguilbert@chromium.org changed reviewers:
+ xhwang@chromium.org

[watk, 2017-02-08 00:52:30]

watk@chromium.org changed reviewers:
+ watk@chromium.org

[watk, 2017-02-08 00:52:31]

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:835: bool UseWebMediaPlayerImpl(const
GURL& url) {
This needs updating to talk about the renderer and not WMP?

[xhwang, 2017-02-08 02:46:01]

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:836: // Always use WMPI for playing blob
URLs since WMPA could never play them very
Drop any reference to WMPA, here and in
https://cs.chromium.org/search/?q=WMPA+package:%5Echromium$&type=cs

https://codereview.chromium.org/2681643006/diff/20001/media/base/media.cc
File media/base/media.cc (right):

https://codereview.chromium.org/2681643006/diff/20001/media/base/media.cc#new...
media/base/media.cc:90: bool ArePlatformDecodersAvailable() {
Maybe we only need HasPlatformDecoderSupport() now.

[Zhiqiang Zhang (Slow), 2017-02-08 11:03:34]

MediaSession tests lgtm. No more flaky tests \o/

[tguilbert, 2017-02-09 02:32:17]

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:835: bool UseWebMediaPlayerImpl(const
GURL& url) {
On 2017/02/08 00:52:30, watk wrote:
> This needs updating to talk about the renderer and not WMP?

Done.

https://codereview.chromium.org/2681643006/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:836: // Always use WMPI for playing blob
URLs since WMPA could never play them very
On 2017/02/08 02:46:01, xhwang_slow wrote:
> Drop any reference to WMPA, here and in
> https://cs.chromium.org/search/?q=WMPA+package:%5Echromium$&type=cs

I have dropped the references here. However, for the remaining TODOs, there are
follow up CLs in which dropping references to WMPA will make more sense (when I
actually complete the TODOs).

https://codereview.chromium.org/2681643006/diff/20001/media/base/media.cc
File media/base/media.cc (right):

https://codereview.chromium.org/2681643006/diff/20001/media/base/media.cc#new...
media/base/media.cc:90: bool ArePlatformDecodersAvailable() {
On 2017/02/08 02:46:01, xhwang_slow wrote:
> Maybe we only need HasPlatformDecoderSupport() now.

I made the switch to HasPlatformDecoderSupport(), but forgot to delete this.
Thanks for catching it!

[tguilbert, 2017-02-09 02:32:26]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 02:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-02-09 03:52:42]

lgtm

[commit-bot: I haz the power, 2017-02-09 07:01:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 07:01:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tguilbert, 2017-02-09 20:18:39]

tguilbert@chromium.org changed reviewers:
+ alexmos@chromium.org

[tguilbert, 2017-02-09 20:18:40]

alexmos@, can you OWNERS review content/*?

Thank you!

[watk, 2017-02-09 20:25:41]

https://codereview.chromium.org/2681643006/diff/40001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2681643006/diff/40001/content/renderer/render...
content/renderer/render_frame_impl.cc:855: // play it with Spitzer, thus fall
back to AVDA. http://crbug.com/642988.
I think the "AVDA" in this comment was always wrong?

Should be: ".. cannot play it with the default renderer so use
MediaPlayerRenderer."

[alexmos, 2017-02-09 23:24:03]

content/ LGTM

[tguilbert, 2017-02-10 01:30:53]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2017-02-10 01:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from zqzhang@chromium.org
Link to the patchset: https://codereview.chromium.org/2681643006/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-02-10 01:31:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:49:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486690253974580,
"parent_rev": "02ca98f26b85b0e7f2d643a45ad88d22ca65c6ce", "commit_rev":
"87552634f69a29a78a732942ad1313349bd8e93d"}

[commit-bot: I haz the power, 2017-02-10 02:50:13]

Description was changed from

==========
Remove kDisableUnifiedMediaPipeline

WMPA has been removed and the Unified Media Pipeline has been
in production for many months now. It's safe to remove the
flag to disable the UMP.

BUG=570711, 646312
==========

to

==========
Remove kDisableUnifiedMediaPipeline

WMPA has been removed and the Unified Media Pipeline has been
in production for many months now. It's safe to remove the
flag to disable the UMP.

BUG=570711, 646312

Review-Url: https://codereview.chromium.org/2681643006
Cr-Commit-Position: refs/heads/master@{#449536}
Committed:
https://chromium.googlesource.com/chromium/src/+/87552634f69a29a78a732942ad13...
==========

[commit-bot: I haz the power, 2017-02-10 02:50:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/87552634f69a29a78a732942ad13...