Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2681643006: Remove kDisableUnifiedMediaPipeline (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/render_frame_impl.cc ('K') | « media/base/mime_util_internal.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index 8d630dc4c14f6b6bc9bf473cd18ae8c6cb16fe16..99be40b5d6275b128f28604273bee58aa041eb4e 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -57,7 +57,6 @@ static void RunCodecSupportTest(const MimeUtil::PlatformInfo& states_to_vary,
MAKE_TEST_VECTOR(has_platform_vp8_decoder);
MAKE_TEST_VECTOR(has_platform_vp9_decoder);
MAKE_TEST_VECTOR(supports_opus);
- MAKE_TEST_VECTOR(is_unified_media_pipeline_enabled);
#undef MAKE_TEST_VECTOR
MimeUtil::PlatformInfo info;
@@ -71,20 +70,16 @@ static void RunCodecSupportTest(const MimeUtil::PlatformInfo& states_to_vary,
RUN_TEST_VECTOR(has_platform_vp8_decoder) {
RUN_TEST_VECTOR(has_platform_vp9_decoder) {
RUN_TEST_VECTOR(supports_opus) {
- RUN_TEST_VECTOR(is_unified_media_pipeline_enabled) {
- for (int codec = MimeUtil::INVALID_CODEC;
- codec <= MimeUtil::LAST_CODEC; ++codec) {
- SCOPED_TRACE(base::StringPrintf(
- "has_platform_decoders=%d, has_platform_vp8_decoder=%d, "
- "supports_opus=%d, "
- "has_platform_vp9_decoder=%d, "
- "is_unified_media_pipeline_enabled=%d, "
- "codec=%d",
- info.has_platform_decoders, info.has_platform_vp8_decoder,
- info.supports_opus, info.has_platform_vp9_decoder,
- info.is_unified_media_pipeline_enabled, codec));
- test_func(info, static_cast<MimeUtil::Codec>(codec));
- }
+ for (int codec = MimeUtil::INVALID_CODEC;
+ codec <= MimeUtil::LAST_CODEC; ++codec) {
+ SCOPED_TRACE(base::StringPrintf(
+ "has_platform_decoders=%d, has_platform_vp8_decoder=%d, "
+ "supports_opus=%d, "
+ "has_platform_vp9_decoder=%d, "
+ "codec=%d",
+ info.has_platform_decoders, info.has_platform_vp8_decoder,
+ info.supports_opus, info.has_platform_vp9_decoder, codec));
+ test_func(info, static_cast<MimeUtil::Codec>(codec));
}
}
}
@@ -100,7 +95,6 @@ static MimeUtil::PlatformInfo VaryAllFields() {
states_to_vary.has_platform_vp8_decoder = true;
states_to_vary.has_platform_vp9_decoder = true;
states_to_vary.supports_opus = true;
- states_to_vary.is_unified_media_pipeline_enabled = true;
states_to_vary.has_platform_decoders = true;
return states_to_vary;
}
@@ -294,76 +288,10 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
});
}
-TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
- // Vary all parameters except |is_unified_media_pipeline_enabled|.
+TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehavior) {
MimeUtil::PlatformInfo states_to_vary = VaryAllFields();
- states_to_vary.is_unified_media_pipeline_enabled = false;
- // Disable the unified pipeline.
MimeUtil::PlatformInfo test_states;
- test_states.is_unified_media_pipeline_enabled = false;
-
- RunCodecSupportTest(
- states_to_vary, test_states,
- [](const MimeUtil::PlatformInfo& info, MimeUtil::Codec codec) {
- const bool result = MimeUtil::IsCodecSupportedOnPlatform(
- codec, kTestMimeType, false, info);
- switch (codec) {
- // These codecs are never supported by the Android platform.
- case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
- case MimeUtil::MPEG2_AAC:
- case MimeUtil::THEORA:
- EXPECT_FALSE(result);
- break;
-
- // These codecs are always available via MediaPlayer.
- case MimeUtil::FLAC:
- case MimeUtil::PCM:
- case MimeUtil::MP3:
- case MimeUtil::MPEG4_AAC:
- case MimeUtil::VORBIS:
- case MimeUtil::H264:
- case MimeUtil::VP8:
- EXPECT_TRUE(result);
- break;
-
- // The remaining codecs depend on the platform version.
- case MimeUtil::OPUS:
- EXPECT_EQ(info.supports_opus, result);
- break;
-
- case MimeUtil::VP9:
- // MediaPlayer only supports VP9 in WebM.
- EXPECT_FALSE(result);
- break;
-
- case MimeUtil::HEVC:
- EXPECT_EQ(HasHevcSupport(), result);
- break;
- }
- });
-
- // Verify vp9 support in WebM.
- RunCodecSupportTest(
- states_to_vary, test_states,
- [](const MimeUtil::PlatformInfo& info, MimeUtil::Codec codec) {
- const bool result = MimeUtil::IsCodecSupportedOnPlatform(
- codec, "video/webm", true, info);
- if (codec == MimeUtil::VP9)
- EXPECT_EQ(info.has_platform_vp9_decoder, result);
- });
-}
-
-TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithUnifiedPipeline) {
- // Vary all parameters except |is_unified_media_pipeline_enabled|.
- MimeUtil::PlatformInfo states_to_vary = VaryAllFields();
- states_to_vary.is_unified_media_pipeline_enabled = false;
-
- // Enable the unified pipeline.
- MimeUtil::PlatformInfo test_states;
- test_states.is_unified_media_pipeline_enabled = true;
RunCodecSupportTest(
states_to_vary, test_states,
@@ -412,9 +340,8 @@ TEST(IsCodecSupportedOnPlatformTest, OpusOggSupport) {
RunCodecSupportTest(
states_to_vary, test_states,
[](const MimeUtil::PlatformInfo& info, MimeUtil::Codec codec) {
- EXPECT_EQ(info.is_unified_media_pipeline_enabled,
- MimeUtil::IsCodecSupportedOnPlatform(
- MimeUtil::OPUS, "audio/ogg", false, info));
+ EXPECT_TRUE(MimeUtil::IsCodecSupportedOnPlatform(
+ MimeUtil::OPUS, "audio/ogg", false, info));
});
}
« content/renderer/render_frame_impl.cc ('K') | « media/base/mime_util_internal.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698