Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2681523002:
Increase the number of TaskScheduler foreground threads in renderers. (Closed)
DescriptionIncrease the number of TaskScheduler foreground threads in renderers.
V8Platform::CallOnBackgroundThread() will soon post tasks to
TaskScheduler instead of WorkerPool. To avoid a perf regression when
this change lands, TaskScheduler should be able to run |num_cores|
of these tasks in parallel.
BUG=659191
Review-Url: https://codereview.chromium.org/2681523002
Cr-Commit-Position: refs/heads/master@{#449295}
Committed: https://chromium.googlesource.com/chromium/src/+/743f8d6db5bc0efd51c3e7ce0fcec1a86886a364
Patch Set 1 #Patch Set 2 : self-review #Patch Set 3 : self-review #
Total comments: 2
Patch Set 4 : do not use RecommededMaxNumberOfThreadsInPool #
Total comments: 4
Patch Set 5 : CR gab #14 #Messages
Total messages: 30 (19 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
fdoray@chromium.org changed reviewers: + gab@chromium.org, robliao@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2681523002/diff/40001/content/renderer/render... File content/renderer/render_process_impl.cc (right): https://codereview.chromium.org/2681523002/diff/40001/content/renderer/render... content/renderer/render_process_impl.cc:126: base::RecommendedMaxNumberOfThreadsInPool( Is using RecommendedMax... better than a std::min(2, SysInfo::NumberOfProcessors())? This way we don't have to specify a fake upper bound.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAnL https://codereview.chromium.org/2681523002/diff/40001/content/renderer/render... File content/renderer/render_process_impl.cc (right): https://codereview.chromium.org/2681523002/diff/40001/content/renderer/render... content/renderer/render_process_impl.cc:126: base::RecommendedMaxNumberOfThreadsInPool( On 2017/02/06 20:07:51, robliao wrote: > Is using RecommendedMax... better than a std::min(2, > SysInfo::NumberOfProcessors())? > > This way we don't have to specify a fake upper bound. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
fdoray@chromium.org changed reviewers: + jam@chromium.org
jam@: PTAL
https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... File content/renderer/render_process_impl.cc (right): https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... content/renderer/render_process_impl.cc:117: // expects to have as many threads as cores available for these tasks. Such a comment is fine to justify CL (i.e. in desc) but doesn't belong in this top-level code IMO. Also, why are these blocking? Blocking + flooding cores with work doesn't typically go together? https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... content/renderer/render_process_impl.cc:118: const int max_num_foreground_file_io_threads = s/file_io/blocking/ now
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
gab@: PTAnL https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... File content/renderer/render_process_impl.cc (right): https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... content/renderer/render_process_impl.cc:117: // expects to have as many threads as cores available for these tasks. On 2017/02/06 21:17:10, gab wrote: > Such a comment is fine to justify CL (i.e. in desc) but doesn't belong in this > top-level code IMO. > > Also, why are these blocking? Blocking + flooding cores with work doesn't > typically go together? Done. The v8 tasks are only blocking in tests. https://codereview.chromium.org/2681523002/diff/60001/content/renderer/render... content/renderer/render_process_impl.cc:118: const int max_num_foreground_file_io_threads = On 2017/02/06 21:17:10, gab wrote: > s/file_io/blocking/ now Taken care of in a separate CL https://codereview.chromium.org/2625213003/
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Increase the number of TaskScheduler foreground blocking threads in renderers. V8Platform::CallOnBackgroundThread() will soon post tasks to TaskScheduler instead of WorkerPool. To avoid a perf regression when this change lands, TaskScheduler should be able to run |num_cores| of these tasks in parallel. BUG=659191 ========== to ========== Increase the number of TaskScheduler foreground threads in renderers. V8Platform::CallOnBackgroundThread() will soon post tasks to TaskScheduler instead of WorkerPool. To avoid a perf regression when this change lands, TaskScheduler should be able to run |num_cores| of these tasks in parallel. BUG=659191 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org, jam@chromium.org Link to the patchset: https://codereview.chromium.org/2681523002/#ps80001 (title: "CR gab #14")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486653641514690,
"parent_rev": "585eef9e386393184fd7ac84290750cb849d04f1", "commit_rev":
"743f8d6db5bc0efd51c3e7ce0fcec1a86886a364"}
Message was sent while issue was closed.
Description was changed from ========== Increase the number of TaskScheduler foreground threads in renderers. V8Platform::CallOnBackgroundThread() will soon post tasks to TaskScheduler instead of WorkerPool. To avoid a perf regression when this change lands, TaskScheduler should be able to run |num_cores| of these tasks in parallel. BUG=659191 ========== to ========== Increase the number of TaskScheduler foreground threads in renderers. V8Platform::CallOnBackgroundThread() will soon post tasks to TaskScheduler instead of WorkerPool. To avoid a perf regression when this change lands, TaskScheduler should be able to run |num_cores| of these tasks in parallel. BUG=659191 Review-Url: https://codereview.chromium.org/2681523002 Cr-Commit-Position: refs/heads/master@{#449295} Committed: https://chromium.googlesource.com/chromium/src/+/743f8d6db5bc0efd51c3e7ce0fce... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/743f8d6db5bc0efd51c3e7ce0fce... |
