Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2625213003: Rename *FileIO TaskScheduler worker pools to *Blocking. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, robliao+watch_chromium.org, jam, gab+watch_chromium.org, asvitkine+watch_chromium.org, darin-cc_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename *FileIO TaskScheduler worker pools to *Blocking. These pools run MayBlock() and WithBaseSyncPrimitives() tasks, so *Blocking is a more appropriate name than *FileIO. BUG=675660 Review-Url: https://codereview.chromium.org/2625213003 Cr-Commit-Position: refs/heads/master@{#451821} Committed: https://chromium.googlesource.com/chromium/src/+/e68b6f952c8cccec38c09a72c90ad4546f169a16

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fizx test #

Patch Set 4 : rebase #

Patch Set 5 : fix values on mobile #

Patch Set 6 : update dates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -41 lines) Patch
M components/task_scheduler_util/browser/initialization.cc View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 4 chunks +16 lines, -14 lines 1 comment Download
M content/renderer/render_process_impl.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 1 2 3 4 3 chunks +8 lines, -7 lines 1 comment Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (22 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-12 19:06:35 UTC) #8
fdoray
On 2017/01/12 19:06:35, fdoray wrote: > PTAL I'll need to update server-side field trial configs ...
3 years, 11 months ago (2017-01-12 19:07:33 UTC) #9
gab
On 2017/01/12 19:07:33, fdoray wrote: > On 2017/01/12 19:06:35, fdoray wrote: > > PTAL > ...
3 years, 11 months ago (2017-01-12 20:01:50 UTC) #10
gab
Done, land and rename configs at will :) Le jeu. 12 janv. 2017 15:01, <gab@chromium.org> ...
3 years, 10 months ago (2017-02-08 20:11:11 UTC) #13
fdoray
PTAL https://codereview.chromium.org/2625213003/diff/100001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2625213003/diff/100001/content/browser/browser_main_loop.cc#newcode437 content/browser/browser_main_loop.cc:437: base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.3, 0), 0.1 -> 0.3 to ...
3 years, 10 months ago (2017-02-16 16:27:40 UTC) #20
gab
lgtm
3 years, 10 months ago (2017-02-16 16:50:36 UTC) #21
fdoray
jam@: Please review changes in content/ eugenebut@: Please review changes in ios/web/ rkaplow@: Please review ...
3 years, 10 months ago (2017-02-16 16:57:37 UTC) #23
Eugene But (OOO till 7-30)
ios lgtm
3 years, 10 months ago (2017-02-16 17:47:03 UTC) #24
robliao
lgtm
3 years, 10 months ago (2017-02-16 18:30:25 UTC) #28
rkaplow
lgtm
3 years, 10 months ago (2017-02-16 21:11:57 UTC) #29
jam
lgtm
3 years, 10 months ago (2017-02-21 16:04:49 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625213003/100001
3 years, 10 months ago (2017-02-21 16:10:21 UTC) #32
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 19:40:37 UTC) #35
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e68b6f952c8cccec38c09a72c90a...

Powered by Google App Engine
This is Rietveld 408576698