Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2681253002: [Browsing Data] Remove unused strings in components (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
Reviewers:
msramek
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Browsing Data] Remove unused strings in components BUG=690075 TEST=builds Review-Url: https://codereview.chromium.org/2681253002 Cr-Commit-Position: refs/heads/master@{#449270} Committed: https://chromium.googlesource.com/chromium/src/+/cc894276d35816ba9051b8ab382fcd1022a8f0a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M components/browsing_data_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
Hi PTAL
3 years, 10 months ago (2017-02-09 01:26:55 UTC) #6
msramek
LGTM. Yes, this was part of some of the first design iterations that ended up ...
3 years, 10 months ago (2017-02-09 09:14:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681253002/1
3 years, 10 months ago (2017-02-09 12:50:57 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 12:55:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc894276d35816ba9051b8ab382f...

Powered by Google App Engine
This is Rietveld 408576698