Issue 2681233004: Make External per-window rather than a static Persistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2681233004: Make External per-window rather than a static Persistent. (Closed)

Created:
3 years, 10 months ago by dcheng

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Make External per-window rather than a static Persistent. Sharing wrappers between contexts is unsafe. BUG=687844 Review-Url: https://codereview.chromium.org/2671673002 Cr-Commit-Position: refs/heads/master@{#447724} (cherry picked from commit f2026d03c0b50a54ca5d4845edb64f65a49deff7) Review-Url: https://codereview.chromium.org/2681233004 . Cr-Commit-Position: refs/branch-heads/2924@{#905} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/b2bd86444285956bcd1a516cb49dd1261270c5d9

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	third_party/WebKit/Source/core/frame/DOMWindow.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/frame/DOMWindow.cpp	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

dcheng

3 years, 10 months ago (2017-02-09 21:10:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b2bd86444285956bcd1a516cb49dd1261270c5d9.