Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Issue 2671673002: Make External per-window rather than a static Persistent. (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make External per-window rather than a static Persistent. Sharing wrappers between contexts is unsafe. BUG=687844 Review-Url: https://codereview.chromium.org/2671673002 Cr-Commit-Position: refs/heads/master@{#447724} Committed: https://chromium.googlesource.com/chromium/src/+/f2026d03c0b50a54ca5d4845edb64f65a49deff7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/DOMWindow.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
3 years, 10 months ago (2017-02-02 06:38:03 UTC) #2
esprehn
lgtm
3 years, 10 months ago (2017-02-02 06:42:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671673002/1
3 years, 10 months ago (2017-02-02 06:43:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f2026d03c0b50a54ca5d4845edb64f65a49deff7
3 years, 10 months ago (2017-02-02 08:27:36 UTC) #11
haraken
3 years, 10 months ago (2017-02-02 10:00:59 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698