Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2680943002: ui: Clean up naming of paint-related identifiers (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
bruthig+ink_drop_chromium.org, chromium-reviews, danakj, dcheng, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, mac-reviews_chromium.org, msw+watch_chromium.org, rouslan+bubble_chromium.org, rsesek+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Clean up naming of paint-related identifiers This is a followup to https://codereview.chromium.org/2640983002 that only changed types. BUG=671433 Review-Url: https://codereview.chromium.org/2680943002 Cr-Commit-Position: refs/heads/master@{#448778} Committed: https://chromium.googlesource.com/chromium/src/+/9873ffbc1356eb8bea6a85792fcbb0372cba95aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -647 lines) Patch
M ui/gfx/canvas.h View 9 chunks +32 lines, -32 lines 0 comments Download
M ui/gfx/canvas.cc View 15 chunks +78 lines, -80 lines 0 comments Download
M ui/gfx/harfbuzz_font_skia.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M ui/gfx/paint_throbber.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/gfx/paint_vector_icon.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M ui/gfx/render_text.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/render_text.cc View 8 chunks +35 lines, -34 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/native_theme/common_theme.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 7 chunks +22 lines, -22 lines 0 comments Download
M ui/native_theme/native_theme_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/native_theme/native_theme_base.cc View 27 chunks +141 lines, -159 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 4 chunks +20 lines, -20 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M ui/views/animation/ink_drop_mask.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/views/animation/ink_drop_painted_layer_delegates.cc View 5 chunks +22 lines, -22 lines 0 comments Download
M ui/views/border.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/button/checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/button/label_button_border.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/radio_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/toggle_button.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/focus_ring.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/focusable_border.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/focusable_rounded_border_mac.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/views/controls/image_view.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/controls/md_slider.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/controls/progress_bar.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M ui/views/controls/scrollbar/cocoa_scroll_bar.mm View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/views/controls/table/table_header.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/views/painter.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M ui/views/round_rect_painter.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/shadow_border.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
enne (OOO)
3 years, 10 months ago (2017-02-07 21:10:47 UTC) #2
sky
LGTM - thanks for coming back to this.
3 years, 10 months ago (2017-02-07 22:51:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680943002/1
3 years, 10 months ago (2017-02-07 22:59:55 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:20:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9873ffbc1356eb8bea6a85792fcb...

Powered by Google App Engine
This is Rietveld 408576698