Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2680933007: Don't allow font scale to be lower than 1.0 (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Don't allow font scale to be lower than 1.0 Many people who're using lower font scale do not expect this behavior, so Let's revert this (logically) for now, and consider a solution for low scale font if necessary. BUG=687770, 646254 Review-Url: https://codereview.chromium.org/2680393002 Cr-Commit-Position: refs/heads/master@{#449124} (cherry picked from commit 4ef351aa3467a587e03d8d19cdd9f280ab8fff4d) Review-Url: https://codereview.chromium.org/2680933007 . Cr-Commit-Position: refs/branch-heads/2987@{#423} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8d5792c797a0850cefd3e1d6169caf2c390b97c9

Patch Set 1 #

Patch Set 2 : Don't allow font scale to be lower than 1.0 #

Patch Set 3 : Don't allow font scale to be lower than 1.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 2 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 10 months ago (2017-02-09 23:59:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8d5792c797a0850cefd3e1d6169caf2c390b97c9.

Powered by Google App Engine
This is Rietveld 408576698