Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2680393002: Don't allow font scale to be lower than 1.0 (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow font scale to be lower than 1.0 Many people who're using lower font scale do not expect this behavior, so Let's revert this (logically) for now, and consider a solution for low scale font if necessary. BUG=687770, 646254 Review-Url: https://codereview.chromium.org/2680393002 Cr-Commit-Position: refs/heads/master@{#449124} Committed: https://chromium.googlesource.com/chromium/src/+/4ef351aa3467a587e03d8d19cdd9f280ab8fff4d

Patch Set 1 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 2 chunks +2 lines, -21 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
oshima
https://codereview.chromium.org/2680393002/diff/60001/chrome/browser/ui/libgtkui/gtk_ui.cc File chrome/browser/ui/libgtkui/gtk_ui.cc (right): https://codereview.chromium.org/2680393002/diff/60001/chrome/browser/ui/libgtkui/gtk_ui.cc#newcode975 chrome/browser/ui/libgtkui/gtk_ui.cc:975: static_cast<int>(kDefaultDPI / 72.0 * size_points + 0.5); + 0.5 ...
3 years, 10 months ago (2017-02-08 21:15:31 UTC) #6
Elliot Glaysher
lgtm
3 years, 10 months ago (2017-02-08 21:16:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680393002/60001
3 years, 10 months ago (2017-02-08 22:02:37 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:06:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4ef351aa3467a587e03d8d19cdd9...

Powered by Google App Engine
This is Rietveld 408576698