Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Issue 2680773003: DevTools: Don't trigger panel switcher shortcut if alt key is held (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
index d1f4732db8c8f9bb3f1f08ee5b33d47a2c2db9bf..09b1242539d5edba39762b2a0be58c5a5852210c 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
@@ -231,12 +231,12 @@ UI.InspectorView = class extends UI.VBox {
*/
_keyDown(event) {
var keyboardEvent = /** @type {!KeyboardEvent} */ (event);
- if (!UI.KeyboardShortcut.eventHasCtrlOrMeta(keyboardEvent))
+ if (!UI.KeyboardShortcut.eventHasCtrlOrMeta(keyboardEvent) || event.altKey || event.shiftKey)
pfeldman 2017/02/07 22:50:16 lgtm, but we might need to merge :(
return;
// Ctrl/Cmd + 1-9 should show corresponding panel.
var panelShortcutEnabled = Common.moduleSetting('shortcutPanelSwitch').get();
- if (panelShortcutEnabled && !event.shiftKey && !event.altKey) {
+ if (panelShortcutEnabled) {
var panelIndex = -1;
if (event.keyCode > 0x30 && event.keyCode < 0x3A)
panelIndex = event.keyCode - 0x31;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698