Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2680683002: Revert of Add a script to merge the PGC files (Closed)

Created:
3 years, 10 months ago by Sébastien Marchand
Modified:
3 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, iannucci
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a script to merge the PGC files (patchset #6 id:120001 of https://codereview.chromium.org/2575543002/ ) Reason for revert: Breaks the PGO bots. Original issue's description: > Add a script to merge the PGC files. > > Workaround for a flakyness in pgomgr.exe where it can run out of address > space while trying to merge all the PGC files at the same time. > > This will also allow to upload the pgd file before running the optimize step. > > BUG=674956 > > Review-Url: https://codereview.chromium.org/2575543002 > Cr-Commit-Position: refs/heads/master@{#448332} > Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962688e50c83597 TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=674956 Review-Url: https://codereview.chromium.org/2680683002 Cr-Commit-Position: refs/heads/master@{#448561} Committed: https://chromium.googlesource.com/chromium/src/+/6c2f8b4bd17f67d03b3e4d85401a0eaa68597afa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -116 lines) Patch
D build/win/merge_pgc_files.py View 1 chunk +0 lines, -116 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sébastien Marchand
Created Revert of Add a script to merge the PGC files
3 years, 10 months ago (2017-02-07 06:10:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680683002/1
3 years, 10 months ago (2017-02-07 06:10:30 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 06:12:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c2f8b4bd17f67d03b3e4d85401a...

Powered by Google App Engine
This is Rietveld 408576698