Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575543002:
Add a script to merge the PGC files (Closed)
|
Created:
4 years ago by Sébastien Marchand Modified:
3 years, 10 months ago Reviewers:
scottmg CC:
chromium-reviews, iannucci Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a script to merge the PGC files.
Workaround for a flakyness in pgomgr.exe where it can run out of address
space while trying to merge all the PGC files at the same time.
This will also allow to upload the pgd file before running the optimize step.
BUG=674956
Review-Url: https://codereview.chromium.org/2575543002
Cr-Original-Commit-Position: refs/heads/master@{#448332}
Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962688e50c83597
Review-Url: https://codereview.chromium.org/2575543002
Cr-Commit-Position: refs/heads/master@{#449082}
Committed: https://chromium.googlesource.com/chromium/src/+/4a19948e1bc13344a301c439445d36b44c207bb1
Patch Set 1 #Patch Set 2 : 2017! #Patch Set 3 : Throw exceptions on error #
Total comments: 2
Patch Set 4 : Simplify. #
Total comments: 2
Patch Set 5 : Add source. #Patch Set 6 : Executable bit. #Patch Set 7 : Fix the x86 part. #Patch Set 8 : Fix the x86 part. #Patch Set 9 : amd64_x86 #Patch Set 10 : amd64 #Patch Set 11 : Always use amd64 #Messages
Total messages: 36 (21 generated)
Description was changed from ========== c# Enter a description of the change. Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. BUG=659369 s ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. BUG=659369 ==========
Patchset #1 (id:1) has been deleted
sebmarchand@chromium.org changed reviewers: + scottmg@chromium.org
Description was changed from ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. BUG=659369 ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. BUG=674956 ==========
Description was changed from ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. BUG=674956 ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 ==========
It turns out that I also need this if I want to archive the PGD files at the end of the profiling step (i.e. if I want to separate the instrumentation/profiling from the optimization), PTAL.
The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... File build/win/merge_pgc_files.py (right): https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... build/win/merge_pgc_files.py:87: iterations = int(len(pgc_files) / pgc_per_iter) + ( This makes my head hurt. :) How about http://stackoverflow.com/a/312464 on pgc_files?
https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... File build/win/merge_pgc_files.py (right): https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... build/win/merge_pgc_files.py:87: iterations = int(len(pgc_files) / pgc_per_iter) + ( On 2017/02/04 02:44:09, scottmg wrote: > This makes my head hurt. :) How about http://stackoverflow.com/a/312464 on > pgc_files? Done, it's much cleaner! Should I link to this post in my code?
On 2017/02/06 16:48:38, Sébastien Marchand wrote: > https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... > File build/win/merge_pgc_files.py (right): > > https://codereview.chromium.org/2575543002/diff/60001/build/win/merge_pgc_fil... > build/win/merge_pgc_files.py:87: iterations = int(len(pgc_files) / pgc_per_iter) > + ( > On 2017/02/04 02:44:09, scottmg wrote: > > This makes my head hurt. :) How about http://stackoverflow.com/a/312464 on > > pgc_files? > > Done, it's much cleaner! Should I link to this post in my code? It's "almost trivial", but sure, might be nice.
lgtm https://codereview.chromium.org/2575543002/diff/80001/build/win/merge_pgc_fil... File build/win/merge_pgc_files.py (right): https://codereview.chromium.org/2575543002/diff/80001/build/win/merge_pgc_fil... build/win/merge_pgc_files.py:88: def _split_in_chunks(items, chunk_size): You could just use pgc_per_iter directly in the body of the function if you think that's clearer. (But this is fine too if you like the generic version better.)
Thanks, committing. https://codereview.chromium.org/2575543002/diff/80001/build/win/merge_pgc_fil... File build/win/merge_pgc_files.py (right): https://codereview.chromium.org/2575543002/diff/80001/build/win/merge_pgc_fil... build/win/merge_pgc_files.py:88: def _split_in_chunks(items, chunk_size): On 2017/02/06 17:57:14, scottmg wrote: > You could just use pgc_per_iter directly in the body of the function if you > think that's clearer. (But this is fine too if you like the generic version > better.) I'll stick with the generic version so it can be extracted and re-used elsewhere directly.
The CQ bit was checked by sebmarchand@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2575543002/#ps100001 (title: "Add source.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by sebmarchand@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2575543002/#ps120001 (title: "Executable bit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1486406985686540,
"parent_rev": "eb78c99e38bdd1c36d8e1b0b4239c303cf62c8ec", "commit_rev":
"6c18b1e861ec6a9c96d24b3bd962688e50c83597"}
Message was sent while issue was closed.
Description was changed from ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 Review-Url: https://codereview.chromium.org/2575543002 Cr-Commit-Position: refs/heads/master@{#448332} Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962...
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/2680683002/ by sebmarchand@chromium.org. The reason for reverting is: Breaks the PGO bots..
Message was sent while issue was closed.
Description was changed from ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 Review-Url: https://codereview.chromium.org/2575543002 Cr-Commit-Position: refs/heads/master@{#448332} Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962... ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 Review-Url: https://codereview.chromium.org/2575543002 Cr-Commit-Position: refs/heads/master@{#448332} Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962... ==========
Patchset #9 (id:180001) has been deleted
PTAnL, I've switched to always using the version of pgomgr.exe from the VC/bin/amd64 directory as it's what seems to work on my PGO trybot (it's a x86 builder). The diff that you want to check is https://codereview.chromium.org/2575543002/diff2/120001:240001/build/win/merg...
lgtm
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 240001, "attempt_start_ts": 1486585428543780,
"parent_rev": "4fa27c5c19dadb9b737cb004c8ad176e8cb45422", "commit_rev":
"4a19948e1bc13344a301c439445d36b44c207bb1"}
Message was sent while issue was closed.
Description was changed from ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 Review-Url: https://codereview.chromium.org/2575543002 Cr-Commit-Position: refs/heads/master@{#448332} Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962... ========== to ========== Add a script to merge the PGC files. Workaround for a flakyness in pgomgr.exe where it can run out of address space while trying to merge all the PGC files at the same time. This will also allow to upload the pgd file before running the optimize step. BUG=674956 Review-Url: https://codereview.chromium.org/2575543002 Cr-Original-Commit-Position: refs/heads/master@{#448332} Committed: https://chromium.googlesource.com/chromium/src/+/6c18b1e861ec6a9c96d24b3bd962... Review-Url: https://codereview.chromium.org/2575543002 Cr-Commit-Position: refs/heads/master@{#449082} Committed: https://chromium.googlesource.com/chromium/src/+/4a19948e1bc13344a301c439445d... ==========
Message was sent while issue was closed.
Committed patchset #11 (id:240001) as https://chromium.googlesource.com/chromium/src/+/4a19948e1bc13344a301c439445d... |
