third_party/WebKit/Source/core/dom/CharacterData.cpp - Issue 2680463003: Remove branch on childNeedsDistributionRecalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CharacterData.cpp

Issue 2680463003: Remove branch on childNeedsDistributionRecalc (Closed)

Patch Set: Add updateDistribution to CharacterData::setDataAndUpdate, and its test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/CharacterData.cpp

diff --git a/third_party/WebKit/Source/core/dom/CharacterData.cpp b/third_party/WebKit/Source/core/dom/CharacterData.cpp

index 47bd7ca3f66fe169625864b769e1fe198805ce72..b4d7022802cd3dd5b89ea12c642db6fa49c4d125 100644

--- a/third_party/WebKit/Source/core/dom/CharacterData.cpp

+++ b/third_party/WebKit/Source/core/dom/CharacterData.cpp

@@ -176,6 +176,8 @@ void CharacterData::setDataAndUpdate(const String& newData,

unsigned oldLength,

unsigned newLength,

UpdateSource source) {

+ document().updateDistribution();

hayato 2017/02/07 07:46:24 This should be (this->)updateDistribution() (Node:

kojii 2017/02/07 08:44:33 Ah, thank you, done in PS3.

if (source != UpdateFromParser)

document().dataWillChange(*this);