third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html - Issue 2680463003: Remove branch on childNeedsDistributionRecalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html

Issue 2680463003: Remove branch on childNeedsDistributionRecalc (Closed)

Patch Set: Add updateDistribution to CharacterData::setDataAndUpdate, and its test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html

diff --git a/third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html b/third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..6b559921ad7de98f9ff47ef1a73452c30ee84be3

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html

@@ -0,0 +1,13 @@

+<!DOCTYPE html>

+<script src='../../resources/testharness.js'></script>

+<script src='../../resources/testharnessreport.js'></script>

+<div id="host">XXX</div>

+<script>

+test(() => {

+ document.body.offsetTop;

+ var root = host.attachShadow({mode:"open"});

+ root.innerHTML = "<slot></slot>";

+ host.firstChild.data = " ";

+ assert_true(true, 'This test must run without crash.');

+}, 'Setting CharacterData.data while distribution is dirty should not cause a crash (crbug.com/673967).' );

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/CharacterData.cpp » ('j') | third_party/WebKit/Source/core/dom/CharacterData.cpp » ('J')