third_party/WebKit/Source/core/dom/Text.cpp - Issue 2680463003: Remove branch on childNeedsDistributionRecalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Text.cpp

Issue 2680463003: Remove branch on childNeedsDistributionRecalc (Closed)

Patch Set: Add updateDistribution to CharacterData::setDataAndUpdate, and its test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Text.cpp

diff --git a/third_party/WebKit/Source/core/dom/Text.cpp b/third_party/WebKit/Source/core/dom/Text.cpp

index 04845a1644e032a15a674bbc13771da76953f6ad..60c166060d8e7fcd013872fc244893f6f883d7d7 100644

--- a/third_party/WebKit/Source/core/dom/Text.cpp

+++ b/third_party/WebKit/Source/core/dom/Text.cpp

@@ -280,11 +280,6 @@ bool Text::textLayoutObjectIsNeeded(const ComputedStyle& style,

if (style.preserveNewline())

return true;

- // childNeedsDistributionRecalc() here is rare, only happens JS calling

- // surroundContents() etc. from DOMNodeInsertedIntoDocument etc.

- if (document().childNeedsDistributionRecalc())

- return true;

// Avoiding creation of a layoutObject for the text node is a non-essential

// memory optimization. So to avoid blowing up on very wide DOMs, we limit

// the number of siblings to visit.