Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(460)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html
Issue
2680463003
:
Remove branch on childNeedsDistributionRecalc (Closed)
Patch Set: Add updateDistribution to CharacterData::setDataAndUpdate, and its test
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/shadow-dom/crashes/character-data-set-data-crash.html
third_party/WebKit/Source/core/dom/CharacterData.cpp
third_party/WebKit/Source/core/dom/Text.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/Source/core/dom/CharacterData.cpp »
('j') |
third_party/WebKit/Source/core/dom/CharacterData.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script src='../../resources/testharness.js'></script>
3
<script src='../../resources/testharnessreport.js'></script>
4
<div id="host">XXX</div>
5
<script>
6
test(() => {
7
document.body.offsetTop;
8
var root = host.attachShadow({mode:"open"});
9
root.innerHTML = "<slot></slot>";
10
host.firstChild.data = " ";
11
assert_true(true, 'This test must run without crash.');
12
}, 'Setting CharacterData.data while distribution is dirty should not cause a cr ash (crbug.com/673967).' );
13
</script>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/Source/core/dom/CharacterData.cpp »
('j') |
third_party/WebKit/Source/core/dom/CharacterData.cpp »
('J')
Issue 2680463003: Remove branch on childNeedsDistributionRecalc (Closed)
Created 3 years, 10 months ago by kojii
Modified 3 years, 10 months ago
Reviewers: hayato, rune
Base URL:
Comments: 5
This is Rietveld
408576698