Introducing 2 usages for SwiftShader

Introducing a second usage for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2680423002
Cr-Commit-Position: refs/heads/master@{#450059}
Committed: https://chromium.googlesource.com/chromium/src/+/2ad66a7079e608873f2e1c8a60bf316c76bbc156

[sugoi1, 2017-02-08 22:43:41]

Description was changed from

==========
Introducing 2 usages for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
==========

to

==========
Introducing 2 usages for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sugoi1, 2017-02-08 22:45:51]

Description was changed from

==========
Introducing 2 usages for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Introducing a second usage for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sugoi1, 2017-02-08 22:45:52]

sugoi@chromium.org changed reviewers:
+ jbauman@chromium.org, kbr@chromium.org

[sugoi1, 2017-02-08 22:46:03]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:46:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi1, 2017-02-08 22:47:43]

I've managed to run Layout Tests locally with SwiftShader on both Windows and
Linux. This cl should be the first step for replacing Mesa by SwiftShader.

[commit-bot: I haz the power, 2017-02-08 23:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:03:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sugoi1, 2017-02-08 23:03:41]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:13:41]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-02-10 00:06:30]

You also need to update content/browser/gpu/gpu_data_manager_impl_private.cc to
use swiftshader-webgl

[sugoi1, 2017-02-10 16:39:38]

Thanks John, good catch. I had somehow missed that one in the code search
results.

https://codereview.chromium.org/2680423002/diff/40001/ui/gl/gl_implementation.cc
File ui/gl/gl_implementation.cc (right):

https://codereview.chromium.org/2680423002/diff/40001/ui/gl/gl_implementation...
ui/gl/gl_implementation.cc:39: {kGLImplementationMockName,
kGLImplementationMockGL}};
Note: The whitespace changes are from 'git cl format'.

[sugoi1, 2017-02-10 16:47:37]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 16:48:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 18:15:13]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-02-10 22:10:48]

Good work Alexis. LGTM as far as I can tell from code examination. John's review
was more thorough than mine so I mainly defer review to him.

I encourage you to get this new configuration running on the bots ASAP so the
new code path doesn't bit-rot.

[sugoi1, 2017-02-10 22:20:40]

On 2017/02/10 22:10:48, Ken Russell wrote:
> Good work Alexis. LGTM as far as I can tell from code examination. John's
review
> was more thorough than mine so I mainly defer review to him.
> 
> I encourage you to get this new configuration running on the bots ASAP so the
> new code path doesn't bit-rot.

Thanks Ken, I just need to land 3 other cls first, but these should happen soon:
1) SwiftShader DEPS roll (currently underway)
2) Pulling the Subzero repo in SwiftShader in Chromium (it's been approved, I
just need the DEPS roll to happen first)
3) Switch the backend for SwiftShader on Windows from LLVM to Subzero, making
sure it builds properly on the bots

Once this is done, I should be able to replace MESA by SwiftShader for the
Layout tests, rebaseline some tests and fix failing tests until they all pass
with SwiftShader.

[Ken Russell (switch to Gerrit), 2017-02-10 22:26:16]

On 2017/02/10 22:20:40, sugoi1 wrote:
> On 2017/02/10 22:10:48, Ken Russell wrote:
> > Good work Alexis. LGTM as far as I can tell from code examination. John's
> review
> > was more thorough than mine so I mainly defer review to him.
> > 
> > I encourage you to get this new configuration running on the bots ASAP so
the
> > new code path doesn't bit-rot.
> 
> Thanks Ken, I just need to land 3 other cls first, but these should happen
soon:
> 1) SwiftShader DEPS roll (currently underway)
> 2) Pulling the Subzero repo in SwiftShader in Chromium (it's been approved, I
> just need the DEPS roll to happen first)
> 3) Switch the backend for SwiftShader on Windows from LLVM to Subzero, making
> sure it builds properly on the bots
> 
> Once this is done, I should be able to replace MESA by SwiftShader for the
> Layout tests, rebaseline some tests and fix failing tests until they all pass
> with SwiftShader.

Awesome! Great work moving this forward. Let me know if you get stuck on any
part.

[jbauman, 2017-02-10 22:26:47]

lgtm

[sugoi1, 2017-02-13 18:24:17]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2017-02-13 18:25:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 20:09:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487010257978860,
"parent_rev": "61133b53686af3b228664959fe557a9717d566bf", "commit_rev":
"2ad66a7079e608873f2e1c8a60bf316c76bbc156"}

[commit-bot: I haz the power, 2017-02-13 20:10:24]

Description was changed from

==========
Introducing a second usage for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Introducing a second usage for SwiftShader

In order to use SwiftShader to run layout tests, SwiftShader
must be usable the same way Mesa currently is: as a full
OpenGL implementation. In order to do that, a few things
were modified:

- A new flag was added:
gl::kGLImplementationSwiftShaderForWebGLName, which is
"--use-gl=swiftshader-webgl"
- The current way of using SwiftShader in Chromium is to
only use SwiftShader for WebGL. To reflect that,
gl::kGLImplementationSwiftShaderName was renamed to
gl::kGLImplementationSwiftShaderForWebGLName. All existing
occurences of the "swiftshader" string in the code were also
replaced with gl::kGLImplementationSwiftShaderForWebGLName.
- The old flag gl::kGLImplementationSwiftShaderName, usable
by setting the "--use-gl=swiftshader" flag, has a new
meaning, which is to use SwiftShader as the OpenGL ES
driver for all of Chromium, not only for WebGL. This will
allow SwiftShader to replace Mesa in the layout tests.

Note: Although the new modes were added, no changes to the
layout tests will happen with this cl, but it does allow
Chromium to use SwiftShader as the OpenGL ES driver on
Windows and Linux.

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2680423002
Cr-Commit-Position: refs/heads/master@{#450059}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ad66a7079e608873f2e1c8a60bf...
==========

[commit-bot: I haz the power, 2017-02-13 20:10:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ad66a7079e608873f2e1c8a60bf...