Count closures using the feedback vector cell map, specialize if count==1.

Count closures using the feedback vector cell map, specialize if count==1.

This introduces new maps to track whether we have created at most one
closure. If we have created just one closure, Turbofan will
specialize the code to its context.

Review-Url: https://codereview.chromium.org/2680313002
Cr-Commit-Position: refs/heads/master@{#43108}
Committed: https://chromium.googlesource.com/v8/v8/+/36ed494784706c3c573c7d5fdd61d93a33dcb91a

[Jarin, 2017-02-08 12:56:54]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 12:57:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 13:17:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 13:17:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/22334)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Jarin, 2017-02-09 12:36:52]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 12:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 12:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 12:54:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Jarin, 2017-02-09 14:49:54]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:11:39]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/20647)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Jarin, 2017-02-10 07:55:03]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org, mvstanton@chromium.org

[Jarin, 2017-02-10 07:55:04]

Could you take a look, please?

(The failing test is a bug in maybe-assigned calculation, I would only land this
once that is fixed.)

[Benedikt Meurer, 2017-02-10 07:58:57]

LGTM.

[mvstanton, 2017-02-10 09:20:41]

thanks! LGTM.

[Jarin, 2017-02-10 13:48:13]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:48:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-02-10 13:49:43]

Description was changed from

==========
Count closures using the feedback vector cell map, specialize if count==1.

This introduces new maps to track whether we have created at most one
closure. If we have created just one closure, Turbofan will
specialize the code to its context.
==========

to

==========
Count closures using the feedback vector cell map, specialize if count==1.

This introduces new maps to track whether we have created at most one
closure. If we have created just one closure, Turbofan will
specialize the code to its context.
==========

[Jarin, 2017-02-10 13:49:43]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2017-02-10 14:04:27]

LGTM.

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/js-create-...
File src/compiler/js-create-lowering.cc (left):

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/js-create-...
src/compiler/js-create-lowering.cc:756: if (!FLAG_turbo_lower_create_closure)
return NoChange();
nit: Please also remove the flag, which should be dead after this. Similar for
the unit test in JSCreateLoweringTest as well.

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:592: info()->MarkAsFunctionContextSpecializing();
suggestion: As discussed offline, we could move this down two or three lines
into the below condition to make sure we only enable the optimization in cases
where we have deoptimization support enabled.

[commit-bot: I haz the power, 2017-02-10 14:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:14:29]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-02-10 14:51:50]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 14:51:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-02-10 14:53:06]

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/js-create-...
File src/compiler/js-create-lowering.cc (left):

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/js-create-...
src/compiler/js-create-lowering.cc:756: if (!FLAG_turbo_lower_create_closure)
return NoChange();
On 2017/02/10 14:04:27, Michael Starzinger wrote:
> nit: Please also remove the flag, which should be dead after this. Similar for
> the unit test in JSCreateLoweringTest as well.

Done.

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2680313002/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:592: info()->MarkAsFunctionContextSpecializing();
On 2017/02/10 14:04:27, Michael Starzinger wrote:
> suggestion: As discussed offline, we could move this down two or three lines
> into the below condition to make sure we only enable the optimization in cases
> where we have deoptimization support enabled.

Done.

[Jarin, 2017-02-10 14:53:18]

The CQ bit was unchecked by jarin@chromium.org

[Jarin, 2017-02-10 14:53:18]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2017-02-10 14:53:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mvstanton@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2680313002/#ps60001
(title: "Only specialize if compiling from bytecode")

[commit-bot: I haz the power, 2017-02-10 14:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 15:19:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486738398702880,
"parent_rev": "0a9d4a3b0c8097dc39ec95f7ab750b59e29cbc8a", "commit_rev":
"36ed494784706c3c573c7d5fdd61d93a33dcb91a"}

[commit-bot: I haz the power, 2017-02-10 15:19:25]

Description was changed from

==========
Count closures using the feedback vector cell map, specialize if count==1.

This introduces new maps to track whether we have created at most one
closure. If we have created just one closure, Turbofan will
specialize the code to its context.
==========

to

==========
Count closures using the feedback vector cell map, specialize if count==1.

This introduces new maps to track whether we have created at most one
closure. If we have created just one closure, Turbofan will
specialize the code to its context.

Review-Url: https://codereview.chromium.org/2680313002
Cr-Commit-Position: refs/heads/master@{#43108}
Committed:
https://chromium.googlesource.com/v8/v8/+/36ed494784706c3c573c7d5fdd61d93a33d...
==========

[commit-bot: I haz the power, 2017-02-10 15:19:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/36ed494784706c3c573c7d5fdd61d93a33d...