Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: test/unittests/compiler/js-create-lowering-unittest.cc

Issue 2680313002: Count closures using the feedback vector cell map, specialize if count==1. (Closed)
Patch Set: Only specialize if compiling from bytecode Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/debugger/debug/debug-set-variable-value.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-create-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-create-lowering-unittest.cc b/test/unittests/compiler/js-create-lowering-unittest.cc
index acdc1fd388a05f97a2453415d231b1035d8cb8f8..7ea1894322473a7d160b72f919d53ca1c2d0f1ef 100644
--- a/test/unittests/compiler/js-create-lowering-unittest.cc
+++ b/test/unittests/compiler/js-create-lowering-unittest.cc
@@ -142,36 +142,6 @@ TEST_F(JSCreateLoweringTest, JSCreateArgumentsInlinedRestArray) {
}
// -----------------------------------------------------------------------------
-// JSCreateClosure
-
-TEST_F(JSCreateLoweringTest, JSCreateClosureViaInlinedAllocation) {
- if (!FLAG_turbo_lower_create_closure) return;
- Node* const context = UndefinedConstant();
- Node* const effect = graph()->start();
- Node* const control = graph()->start();
- Handle<SharedFunctionInfo> shared(isolate()->number_function()->shared());
-
- // Create a mock feedback vector. It just has to be an array with an array
- // in slot 0.
- Handle<FixedArray> array = isolate()->factory()->NewFixedArray(
- FeedbackVector::kReservedIndexCount + 1);
- array->set_map_no_write_barrier(isolate()->heap()->feedback_vector_map());
- Handle<FeedbackVector> vector = Handle<FeedbackVector>::cast(array);
- FeedbackSlot slot(0);
- vector->Set(slot, *vector);
- VectorSlotPair pair(vector, slot);
-
- Reduction r = Reduce(
- graph()->NewNode(javascript()->CreateClosure(shared, pair, NOT_TENURED),
- context, effect, control));
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(),
- IsFinishRegion(IsAllocate(IsNumberConstant(JSFunction::kSize),
- IsBeginRegion(_), control),
- _));
-}
-
-// -----------------------------------------------------------------------------
// JSCreateFunctionContext
TEST_F(JSCreateLoweringTest, JSCreateFunctionContextViaInlinedAllocation) {
« no previous file with comments | « test/debugger/debug/debug-set-variable-value.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698