Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2680263003: Remove the iOS QR Code scanner experiment code. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove the iOS QR Code scanner experiment code. This allows listing the QR Code scanner entry directly in the .plist listing the force touch actions, as opposed to adding it at runtime, BUG=675625 Review-Url: https://codereview.chromium.org/2676803002 Cr-Commit-Position: refs/heads/master@{#448016} (cherry picked from commit 5f067c6fa15e295d45c51946470567d5cd1baca3) Review-Url: https://codereview.chromium.org/2680263003 . Cr-Commit-Position: refs/branch-heads/2987@{#382} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a93b8677d27b882fab26d18173748a54ff432110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -141 lines) Patch
M ios/chrome/app/application_delegate/user_activity_handler.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M ios/chrome/app/application_delegate/user_activity_handler_unittest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M ios/chrome/app/main_controller.mm View 6 chunks +1 line, -36 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/app/resources/Info.plist View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/chrome/app/resources/chrome_localize_strings_config.plist View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/chrome/app/resources/quick_action_qr_scanner@2x.png View Binary file 0 comments Download
A + ios/chrome/app/resources/quick_action_qr_scanner@3x.png View Binary file 0 comments Download
M ios/chrome/app/spotlight/actions_spotlight_manager.mm View 1 chunk +12 lines, -19 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/app_startup_parameters.mm View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm View 3 chunks +0 lines, -8 lines 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/Contents.json View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@2x.png View Binary file 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@3x.png View Binary file 0 comments Download

Messages

Total messages: 2 (1 generated)
jif
3 years, 10 months ago (2017-02-08 09:44:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a93b8677d27b882fab26d18173748a54ff432110.

Powered by Google App Engine
This is Rietveld 408576698