Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2676803002: Remove the iOS QR Code scanner experiment code. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, arv+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the iOS QR Code scanner experiment code. This allows listing the QR Code scanner entry directly in the .plist listing the force touch actions, as opposed to adding it at runtime, BUG=675625 Review-Url: https://codereview.chromium.org/2676803002 Cr-Commit-Position: refs/heads/master@{#448016} Committed: https://chromium.googlesource.com/chromium/src/+/5f067c6fa15e295d45c51946470567d5cd1baca3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Total comments: 2

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -141 lines) Patch
M ios/chrome/app/application_delegate/user_activity_handler.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M ios/chrome/app/application_delegate/user_activity_handler_unittest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M ios/chrome/app/main_controller.mm View 1 6 chunks +1 line, -36 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/app/resources/Info.plist View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/chrome/app/resources/chrome_localize_strings_config.plist View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/chrome/app/resources/quick_action_qr_scanner@2x.png View Binary file 0 comments Download
A + ios/chrome/app/resources/quick_action_qr_scanner@3x.png View Binary file 0 comments Download
M ios/chrome/app/spotlight/actions_spotlight_manager.mm View 1 2 1 chunk +12 lines, -19 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/app_startup_parameters.mm View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm View 3 chunks +0 lines, -8 lines 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/Contents.json View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@2x.png View Binary file 0 comments Download
D ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/quick_action_qr_scanner@3x.png View Binary file 0 comments Download

Messages

Total messages: 18 (11 generated)
jif
ptal
3 years, 10 months ago (2017-02-03 15:39:13 UTC) #8
sdefresne
Did you build this? https://codereview.chromium.org/2676803002/diff/1/ios/chrome/app/main_controller.mm File ios/chrome/app/main_controller.mm (right): https://codereview.chromium.org/2676803002/diff/1/ios/chrome/app/main_controller.mm#newcode199 ios/chrome/app/main_controller.mm:199: NSString* const kAddApplicationShortcutItems = @"AddApplicationShortcutItems"; ...
3 years, 10 months ago (2017-02-03 15:47:28 UTC) #9
jif
forgot to send the last commit... sorry. ptal.
3 years, 10 months ago (2017-02-03 16:15:04 UTC) #10
sdefresne
lgtm https://codereview.chromium.org/2676803002/diff/20001/ios/chrome/app/spotlight/actions_spotlight_manager.mm File ios/chrome/app/spotlight/actions_spotlight_manager.mm (right): https://codereview.chromium.org/2676803002/diff/20001/ios/chrome/app/spotlight/actions_spotlight_manager.mm#newcode173 ios/chrome/app/spotlight/actions_spotlight_manager.mm:173: [strongSelf getItemForAction:qrScannerAction title:qrScannerTitle] nit: keep the trailing comma ...
3 years, 10 months ago (2017-02-03 16:16:42 UTC) #11
jif
thank you! https://codereview.chromium.org/2676803002/diff/20001/ios/chrome/app/spotlight/actions_spotlight_manager.mm File ios/chrome/app/spotlight/actions_spotlight_manager.mm (right): https://codereview.chromium.org/2676803002/diff/20001/ios/chrome/app/spotlight/actions_spotlight_manager.mm#newcode173 ios/chrome/app/spotlight/actions_spotlight_manager.mm:173: [strongSelf getItemForAction:qrScannerAction title:qrScannerTitle] On 2017/02/03 16:16:42, sdefresne ...
3 years, 10 months ago (2017-02-03 16:22:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676803002/40001
3 years, 10 months ago (2017-02-03 16:22:36 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 17:37:23 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5f067c6fa15e295d45c519464705...

Powered by Google App Engine
This is Rietveld 408576698