Issue 2680163007: Make the information icon in the account chooser consume the mouse click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2680163007: Make the information icon in the account chooser consume the mouse click. (Closed)

Created:
3 years, 10 months ago by vasilii

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Make the information icon in the account chooser consume the mouse click. This affects both Views platforms and Mac. BUG=690061 Review-Url: https://codereview.chromium.org/2687533006 Cr-Commit-Position: refs/heads/master@{#449040} (cherry picked from commit f8ac642ad2d6c45b0a6d293e753997bcb03470cd) Review-Url: https://codereview.chromium.org/2680163007 . Cr-Commit-Position: refs/branch-heads/2987@{#411} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/322486c1cd367137f0063b89ecd2aaf91a175c97

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm	View		2 chunks	+17 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/passwords/credentials_item_view.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

vasilii

3 years, 10 months ago (2017-02-09 19:19:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
322486c1cd367137f0063b89ecd2aaf91a175c97.