Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2687533006: Make the information icon in the account chooser consume the mouse click. (Closed)

Created:
3 years, 10 months ago by vasilii
Modified:
3 years, 10 months ago
Reviewers:
cfroussios
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the information icon in the account chooser consume the mouse click. This affects both Views platforms and Mac. BUG=690061 Review-Url: https://codereview.chromium.org/2687533006 Cr-Commit-Position: refs/heads/master@{#449040} Committed: https://chromium.googlesource.com/chromium/src/+/f8ac642ad2d6c45b0a6d293e753997bcb03470cd

Patch Set 1 #

Patch Set 2 : Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 1 2 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
vasilii
Hi Christos, please review.
3 years, 10 months ago (2017-02-08 17:15:52 UTC) #10
cfroussios
lgtm
3 years, 10 months ago (2017-02-08 17:29:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687533006/20001
3 years, 10 months ago (2017-02-08 17:29:38 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 18:34:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8ac642ad2d6c45b0a6d293e7539...

Powered by Google App Engine
This is Rietveld 408576698