[debugger] extend whitelist for side-effect free debug-evaluate.

[debugger] extend whitelist for side-effect free debug-evaluate.

R=jgruber@chromium.org
BUG=v8:5821
Review-Url: https://codereview.chromium.org/2680163005
Cr-Commit-Position: refs/heads/master@{#43061}
Committed: https://chromium.googlesource.com/v8/v8/+/93c1e73d06ad852c1c2a21829f2b7ab6450422f8

[jgruber, 2017-02-09 10:47:45]

lgtm

https://codereview.chromium.org/2680163005/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2680163005/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:376: case Bytecode::kForInPrepare:
There's also a corresponding runtime function you could whitelist. ForInContinue
also looks ok to whitelist.

[Yang, 2017-02-09 11:23:00]

https://codereview.chromium.org/2680163005/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2680163005/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:376: case Bytecode::kForInPrepare:
On 2017/02/09 10:47:45, jgruber wrote:
> There's also a corresponding runtime function you could whitelist.
ForInContinue
> also looks ok to whitelist.

Done.

[Yang, 2017-02-09 11:33:33]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-09 11:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2680163005/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-09 11:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-02-09 11:55:27]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2017-02-09 14:17:54]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-09 14:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2680163005/#ps40001
(title: "inspector API change got reverted")

[commit-bot: I haz the power, 2017-02-09 14:18:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 14:40:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486649874227480,
"parent_rev": "3186653665ccf618de48868337a43abbe5b894a1", "commit_rev":
"93c1e73d06ad852c1c2a21829f2b7ab6450422f8"}

[commit-bot: I haz the power, 2017-02-09 14:40:34]

Description was changed from

==========
[debugger] extend whitelist for side-effect free debug-evaluate.

R=jgruber@chromium.org
BUG=v8:5821
==========

to

==========
[debugger] extend whitelist for side-effect free debug-evaluate.

R=jgruber@chromium.org
BUG=v8:5821

Review-Url: https://codereview.chromium.org/2680163005
Cr-Commit-Position: refs/heads/master@{#43061}
Committed:
https://chromium.googlesource.com/v8/v8/+/93c1e73d06ad852c1c2a21829f2b7ab6450...
==========

[commit-bot: I haz the power, 2017-02-09 14:40:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/93c1e73d06ad852c1c2a21829f2b7ab6450...