[debugger] extend whitelist for side-effect free debug-evaluate.

src/debug/debug-evaluate.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug-evaluate.h"
 
 #include "src/accessors.h"
 #include "src/compiler.h"
 #include "src/contexts.h"
 #include "src/debug/debug-frames.h"
@@ skipping 253 matching lines @@
     // Whitelist for intrinsics amd runtime functions.
     // Conversions.
     case Runtime::kToInteger:
     case Runtime::kInlineToInteger:
     case Runtime::kToObject:
     case Runtime::kInlineToObject:
     case Runtime::kToString:
     case Runtime::kInlineToString:
     case Runtime::kToLength:
     case Runtime::kInlineToLength:
+    // Type checks.
+    case Runtime::kIsJSReceiver:
+    case Runtime::kInlineIsJSReceiver:
+    case Runtime::kIsSmi:
+    case Runtime::kInlineIsSmi:
+    case Runtime::kIsArray:
+    case Runtime::kIsFunction:
+    case Runtime::kIsDate:
+    case Runtime::kIsJSProxy:
+    case Runtime::kIsRegExp:
+    case Runtime::kIsTypedArray:
     // Loads.
     case Runtime::kLoadLookupSlotForCall:
     // Errors.
+    case Runtime::kReThrow:
     case Runtime::kThrowReferenceError:
+    case Runtime::kThrowSymbolIteratorInvalid:
+    case Runtime::kThrowIteratorResultNotAnObject:
+    case Runtime::kNewTypeError:
     // Strings.
     case Runtime::kInlineStringCharCodeAt:
     case Runtime::kStringCharCodeAt:
     case Runtime::kStringIndexOf:
     case Runtime::kStringReplaceOneCharWithString:
     case Runtime::kSubString:
     case Runtime::kInlineSubString:
     case Runtime::kStringToLowerCase:
     case Runtime::kStringToUpperCase:
     case Runtime::kRegExpInternalReplace:
@@ skipping 57 matching lines @@
     // Contexts.
     case Bytecode::kCreateBlockContext:
     case Bytecode::kCreateCatchContext:
     case Bytecode::kCreateFunctionContext:
     case Bytecode::kCreateEvalContext:
     case Bytecode::kCreateWithContext:
     // Literals.
     case Bytecode::kCreateArrayLiteral:
     case Bytecode::kCreateObjectLiteral:
     case Bytecode::kCreateRegExpLiteral:
+    // Allocations.
+    case Bytecode::kCreateClosure:
+    case Bytecode::kCreateUnmappedArguments:
+    // Conversions.
+    case Bytecode::kToObject:
     // Misc.
-    case Bytecode::kCreateUnmappedArguments:
+    case Bytecode::kForInPrepare:

[jgruber, 2017/02/09 10:47:45]

There's also a corresponding runtime function you could whitelist. ForInContinue
also looks ok to whitelist.

[Yang, 2017/02/09 11:23:00]

Done.

+    case Bytecode::kForInNext:
+    case Bytecode::kForInStep:
     case Bytecode::kThrow:
+    case Bytecode::kReThrow:
     case Bytecode::kIllegal:
     case Bytecode::kCallJSRuntime:
     case Bytecode::kStackCheck:
     case Bytecode::kReturn:
     case Bytecode::kSetPendingMessage:
       return true;
     default:
       if (FLAG_trace_side_effect_free_debug_evaluate) {
         PrintF("[debug-evaluate] bytecode %s may cause side effect.\n",
                Bytecodes::ToString(bytecode));
       }
       return false;
   }
 }
 
 bool BuiltinHasNoSideEffect(Builtins::Name id) {
   switch (id) {
     // Whitelist for builtins.
+    // Array builtins.
+    case Builtins::kArrayPrototypeValues:
     // Math builtins.
     case Builtins::kMathAbs:
     case Builtins::kMathAcos:
     case Builtins::kMathAcosh:
     case Builtins::kMathAsin:
     case Builtins::kMathAsinh:
     case Builtins::kMathAtan:
     case Builtins::kMathAtanh:
     case Builtins::kMathAtan2:
     case Builtins::kMathCeil:
@@ skipping 126 matching lines @@
 
   if (FLAG_trace_side_effect_free_debug_evaluate) {
     PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n",
            reinterpret_cast<void*>(function_addr));
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace v8