Animations: Smooth interpolation for translate none

Animations: Smooth interpolation for translate none

When translate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0px

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873
Review-Url: https://codereview.chromium.org/2680163004
Cr-Commit-Position: refs/heads/master@{#449549}
Committed: https://chromium.googlesource.com/chromium/src/+/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0

[Eric Willigers, 2017-02-08 11:43:32]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 11:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 13:02:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 13:02:09]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Eric Willigers, 2017-02-08 21:04:24]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-10 00:35:16]

lgtm after comment.

https://codereview.chromium.org/2680163004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
(right):

https://codereview.chromium.org/2680163004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp:70:
return InterpolationValue(InterpolableList::create(0));
Let's have createNoneValue() and isNoneValue() wrappers. They can deal with
InterpolationValues to keep the code tidy, there's next to no performance cost
to doing so.

[Eric Willigers, 2017-02-10 03:14:14]

https://codereview.chromium.org/2680163004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
(right):

https://codereview.chromium.org/2680163004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp:70:
return InterpolationValue(InterpolableList::create(0));
On 2017/02/10 00:35:16, alancutter wrote:
> Let's have createNoneValue() and isNoneValue() wrappers. They can deal with
> InterpolationValues to keep the code tidy, there's next to no performance cost
> to doing so.

Done.

[Eric Willigers, 2017-02-10 03:14:21]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-10 03:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2680163004/#ps20001
(title: "createNoneValue isNoneValue")

[commit-bot: I haz the power, 2017-02-10 03:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 03:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 03:30:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2017-02-10 03:36:01]

+sashab for core/css

[Eric Willigers, 2017-02-10 03:36:23]

ericwilligers@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-02-10 04:02:35]

rs lgtm core/css

[Eric Willigers, 2017-02-10 05:12:07]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-02-10 05:12:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 05:27:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486703527991280,
"parent_rev": "7c916610d4392731e6520d2bfd60c674303bb7a9", "commit_rev":
"f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0"}

[commit-bot: I haz the power, 2017-02-10 05:29:06]

Description was changed from

==========
Animations: Smooth interpolation for translate none

When translate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0px

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873
==========

to

==========
Animations: Smooth interpolation for translate none

When translate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0px

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873

Review-Url: https://codereview.chromium.org/2680163004
Cr-Commit-Position: refs/heads/master@{#449549}
Committed:
https://chromium.googlesource.com/chromium/src/+/f05f8abb0c65ea13a76fcf6b49cf...
==========

[commit-bot: I haz the power, 2017-02-10 05:29:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f05f8abb0c65ea13a76fcf6b49cf...