third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 2680163004: Animations: Smooth interpolation for translate none

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 2680163004: Animations: Smooth interpolation for translate none (Closed)

Patch Set: createNoneValue isNoneValue Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

index 97d0bf45f000bfeb95e81df3908fd38824c823c5..4ce9727643ed50488195d26630145257ada046cd 100644

--- a/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -749,6 +749,10 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property,

TranslateTransformOperation* translate =

toTranslateTransformOperation(animatableValueToTransformOperation(

value, TransformOperation::Translate3D));

+ if (!translate) {

+ style->setTranslate(nullptr);

+ return;

+ }

double sourceZoom = toAnimatableTransform(value)->zoom();

double destinationZoom = style->effectiveZoom();

style->setTranslate(

« no previous file with comments | « third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp ('k') | no next file » | no next file with comments »